Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve services initialization #6

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Improve services initialization #6

merged 2 commits into from
Mar 14, 2023

Conversation

outcatcher
Copy link
Owner

Add initializer service

Fix logging during request handling

Add tests for logging

Fix various issues

Add initializer service

Fix logging during request handling

Fix various issues

Add tests for logging
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 79.24% and project coverage change: +18.29 🎉

Comparison is base (a839302) 32.91% compared to head (f0288c9) 51.21%.

❗ Current head f0288c9 differs from pull request most recent head 0ce8a3f. Consider uploading reports for the commit 0ce8a3f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #6       +/-   ##
===========================================
+ Coverage   32.91%   51.21%   +18.29%     
===========================================
  Files          30       23        -7     
  Lines         720      576      -144     
===========================================
+ Hits          237      295       +58     
+ Misses        457      252      -205     
- Partials       26       29        +3     
Impacted Files Coverage Δ
domains/auth/dto/auth.go 50.00% <ø> (ø)
domains/auth/auth.go 61.53% <20.00%> (-11.19%) ⬇️
domains/users/service.go 59.09% <20.00%> (-13.14%) ⬇️
domains/services/initializer.go 92.30% <92.30%> (ø)
domains/api/middlewares/errors.go 73.33% <100.00%> (+73.33%) ⬆️
domains/services/dto/services.go 50.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@outcatcher outcatcher merged commit 2a01da3 into main Mar 14, 2023
@outcatcher outcatcher deleted the initializator branch March 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant