Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx full config optional (via installer) #152

Merged
merged 2 commits into from
May 8, 2021

Conversation

fastlorenzo
Copy link
Collaborator

The installer will comment/uncomment the include reference to the part that is used only in the "full" install mode.

Fixes #150

@github-actions github-actions bot added elkserver Related to RedELK server components installer Related to RedELK installers labels Apr 20, 2021
@xychix
Copy link
Collaborator

xychix commented Apr 29, 2021

Bit thrown off here. is LetsEncrypt the default by now? Guess that wouldn't work in our environment does this mean wel always run dev? or should it be the other way around and make LE an additional flag.

Also kinda more @MarcOverIP territory

Signed-off-by: fastlorenzo <git@bernardi.be>
Signed-off-by: fastlorenzo <git@bernardi.be>
@fastlorenzo
Copy link
Collaborator Author

@xychix nope, it's just a fix that applies only for Let's Encrypt, which is using symlinks to parent directory (so if you mount the base directory that contains the certificates, Nginx will complain as the referenced files are outside the mounted folder, and thus not accessible to docker)

@MarcOverIP
Copy link
Member

@xychix no worries, Le's Encrypt is optional and not the default.

@fastlorenzo have you fully tested this change?

@fastlorenzo
Copy link
Collaborator Author

with the full install, yes (spinned up a clean server in Azure and did the test with this branch and LE).
There is apparently still an issue to be fixed for the limited install though, I'll try to test it this week so we can merge

@MarcOverIP
Copy link
Member

MarcOverIP commented May 5, 2021

Cool, thnx. You also testing without using LE?

@fastlorenzo
Copy link
Collaborator Author

will do ;)

@fastlorenzo
Copy link
Collaborator Author

Fully tested and ready to be merged

@MarcOverIP MarcOverIP merged commit 2ea619a into outflanknl:master May 8, 2021
@fastlorenzo fastlorenzo deleted the fix-nginx branch May 8, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elkserver Related to RedELK server components installer Related to RedELK installers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reopening #148 - redelk-nginx fails to start due to upstream dependencies
3 participants