-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nginx full config optional (via installer) #152
Conversation
Bit thrown off here. is LetsEncrypt the default by now? Guess that wouldn't work in our environment does this mean wel always run dev? or should it be the other way around and make LE an additional flag. Also kinda more @MarcOverIP territory |
Signed-off-by: fastlorenzo <git@bernardi.be>
Signed-off-by: fastlorenzo <git@bernardi.be>
@xychix nope, it's just a fix that applies only for Let's Encrypt, which is using symlinks to parent directory (so if you mount the base directory that contains the certificates, Nginx will complain as the referenced files are outside the mounted folder, and thus not accessible to docker) |
@xychix no worries, Le's Encrypt is optional and not the default. @fastlorenzo have you fully tested this change? |
with the full install, yes (spinned up a clean server in Azure and did the test with this branch and LE). |
Cool, thnx. You also testing without using LE? |
will do ;) |
Fully tested and ready to be merged |
The installer will comment/uncomment the include reference to the part that is used only in the "full" install mode.
Fixes #150