Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon in 3 sizes #381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add favicon in 3 sizes #381

wants to merge 1 commit into from

Conversation

krysal
Copy link

@krysal krysal commented May 13, 2020

Hi! Thank you for the great work Outreachy do and brings.

I made a simple favicon from the stair of the Outreachy logo, in three sizes, a website feels incomplete without its own favicon. This may fix #333 if you like it.

Comments are welcome.

@djmitche
Copy link
Contributor

It looks like the stairsteps have different heights (24 and 20 pixels in the largest one) -- is that original to the outreachy logo?

@krysal
Copy link
Author

krysal commented May 13, 2020

Yes, they have different heights in the original logo. I took the stair from there and touched the pixels a bit because resizing deforms the image, but only to make the colors more defined.

Should they be the same height?

@djmitche
Copy link
Contributor

Ah, interesting -- I didn't know that. I will defer to @sagesharp then!

@sagesharp
Copy link
Collaborator

Hi @krysal! Thanks for doing this for us. 😸 I'll need to pull down this branch to take a look at the work, so apologies for the delayed response.

As for the mis-matched heights, Marie Nordin (Outreachy Fedora coordinator) was the original artist for the Outreachy logo. I'll send an email to her and ask her to weigh in on the favicon stair heights.

@riecatnor
Copy link

Hey folks! I took a look at the original file, and the steps were designed with two different heights. I am not opposed to a change here if everyone agrees it would make more sense for them to be equal. It has been some years since I created the design... it might have been the case that I played around with it and this looked a bit more visually appealing, no further reasoning than that. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Outreachy favicon on title bar
4 participants