server: fix nic path update #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-mgo
requested changes
Mar 16, 2020
| @@ -991,13 +991,11 @@ void Graph::LinkSniffer(const app::Nic &nic, Graph::BrickShrPtr n_sniffer) { | |||
|
|
|||
| if (nic.bypass_filtering) { | |||
| unlink(g_nic->vhost); | |||
| g_nic->head = n_sniffer; | |||
There was a problem hiding this comment.
it was broken, it's still broken(because it's ignore the possibility of a switch), either fix this, or error out any use of that branch, thanks
api/server/graph.cc
Outdated
|
|
||
| found = update_path.find_last_of("/"); | ||
| upath = update_path.substr(0,found); | ||
| if (nic.packet_trace_path == upath) { |
There was a problem hiding this comment.
I think you need to evaluate the full path, I mean it's okay to change path from /tmp/bibi.pcap to /home/titi/bibi.pcap.
and your code ignore that case
outscale-toa
force-pushed
the
path_update
branch
from
173fb51
to
7d56cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.