Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owner alias plugin #12

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Conversation

outscale-mgo
Copy link
Contributor

Note that I didn't test it with new plugin system, but only with old packer repository.
Closes #10

fix outscale#10

Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
@marinsalinas
Copy link
Contributor

@SwampDragons is there any new way to test the new changes over the builers?

@sylviamoss
Copy link
Contributor

@marinsalinas Yes. If you run make dev, the plugin will be installed under ~/.packer.d/plugins/ as packer-plugin-outscale. Any Packer from v1.7.0 should be able to discover the plugin and use it instead of the built-in one. 🤔

@azr
Copy link
Contributor

azr commented Apr 21, 2021

You can also run go build . && packer run test.pkr.hcl, Packer will discover the plugin if it is in the cwd

@SwampDragons
Copy link
Contributor

Have we started the partner conversation about transferring ownership of this repo to Outscale so you don't need to wait on our merge approval?

@RomLecat
Copy link
Contributor

@SwampDragons I don't think so.

With this separate repo and the possibility of Outscale being owner of it, would osc builders still part of the main Packer binary, or would it be more like Terraform (separate binary, and possibly a repository) ?

@sylviamoss
Copy link
Contributor

@Hakujou Currently the osc builders are being vedored in Packer here and all of its code now is in this repository and should remain in it. In the near future plugins won't be vondered anymore and the binaries will have to be downloaded with packer init + required_plugins block. So yeah, since breakout this plugin now has a separate binary and repository.

@outscale-mgo
Copy link
Contributor Author

You can also run go build . && packer run test.pkr.hcl, Packer will discover the plugin if it is in the cwd

Thanks, Just test that on my machine, it work.

@SwampDragons
Copy link
Contributor

To expand on what Moss said, the binary will be separate, but installation will happen seamlessly via the init command and a "packer" block in the config file. Documentation will remain on the Packer.io website, with a "partner" tag to show that it is being maintained by someone in a partner relationship with HashiCorp.

@RomLecat
Copy link
Contributor

@sylviamoss @SwampDragons Ok, thanks a lot. I'll need to discuss it with other Outscale employees as it's not a kind of decision I can take alone.
Once we have figured this out, should we apply through Hashicorp Tech Partner page (https://www.hashicorp.com/go/tech-partner), or should I reach @SwampDragons directly by mp ?

Until then, this MR has been tested and is working, it can be merged :)

@sylviamoss
Copy link
Contributor

Thanks, @Hakujou. I'll let @SwampDragons give you the information on which is the best channel for you to reach out to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use of owner-alias field for owners field in Outscale builders
6 participants