Fix Snabbdom patching issue #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efined for DataObject for more type safety. Automatically create a key if not provided and a changeable is present.
|
I wonder if this could potentially help with #7 ? |
|
Wow! That's really awesome! Thank you so so much! The only small thing I'd like to add is a test case that tests this behaviour, we could probably use the minimal test case you gave in #38. I can add it myself if you're too busy. Again, thank you so much! |
|
I added a test case for this behaviour. |
|
Thank you again, really appreciate this! I'll make a release later today! |
|
@LukaJCB You're welcome! Thank you for outwatch, it's an awesome project. |
|
Version 0.10.1 is live! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #38.
The patch assigns a key to a VNode's data object that contains changeables and doesn't already have a key in order to force Snabbdom to destroy/re-create it when patched with new changeables. It also fixes the
DataObject.updateAttributesmethod by passing the key to the newly constructedDataObject.I've also been doing some refactoring, most notably turned DataObject and Hooks in the Snabbdom facade into
@ScalaJSDefinedtraits for extra type safety (this would have prevented theDataObject.updateAttributesbug for example).