Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactorings in Sink #41

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Conversation

mariusmuja
Copy link
Collaborator

A few refactorings in Sink, made a code a bit more DRY, added onError and onComplete arguments to Sink.create.

@LukaJCB
Copy link
Member

LukaJCB commented Jun 29, 2017

Hey @mariusmuja! Great work! Really appreciate it! However, I'm not sure why exactly we'd need onError and onComplete arguments. The streams used for Sinks are usually infinite and don't include errors, no?

@mariusmuja
Copy link
Collaborator Author

@LukaJCB Yes, that's true. However Sinks can also be used for network communication (websockets for example), in which case network errors can occur. Also, the onError and onComplete arguments have default values, so the Socket.create usage remains the same in most cases.

@LukaJCB LukaJCB merged commit 5e83091 into outwatch:master Jun 30, 2017
@mariusmuja mariusmuja deleted the sink_refactorings branch November 21, 2017 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants