Product of references in different scope

Fixes:vgvassilev#1014
ovdiiuv · Aug 6, 2024 · aee9fec · aee9fec
1 parent 7cec7c8
commit aee9fec
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/lib/Differentiator/ReverseModeVisitor.cpp b/lib/Differentiator/ReverseModeVisitor.cpp
@@ -2295,7 +2295,15 @@ Expr* getArraySizeExpr(const ArrayType* AT, ASTContext& context,
       StmtDiff RResult;
       // If R has no side effects, it can be just cloned
       // (no need to store it).
-      if (!ShouldRecompute(R)) {
+
+      // Check if the local variable declaration is reference type, since it is moved to the global scope and the right side should be recomputed
+      bool promoteToFnScope = false;
+      auto* RDeclRef = dyn_cast<DeclRefExpr>(R->IgnoreImplicit());
+      if (RDeclRef)
+        promoteToFnScope = RDeclRef->getDecl()->getType()->isReferenceType() &&
+                           !getCurrentScope()->isFunctionScope();
+
+      if (!ShouldRecompute(R) || promoteToFnScope) {
         RDelayed = std::unique_ptr<DelayedStoreResult>(
             new DelayedStoreResult(DelayedGlobalStoreAndRef(R)));
         RResult = RDelayed->Result;