fix(win): bugs with files in roots / bugs with resolver and unc shares #11155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does not link? 
|
| @@ -736,7 +738,12 @@ pub fn normalizeStringGenericTZ( | |||
| } | |||
| if (path_[1] != ':') { | |||
| // UNC paths | |||
| @memcpy(buf[buf_i .. buf_i + 2], &comptime strings.literalBuf(T, sep_str ++ sep_str)); | |||
| if (options.add_nt_prefix) { | |||
| @memcpy(buf[buf_i .. buf_i + 4], &comptime strings.literalBuf(T, "UNC" ++ sep_str)); | |||
There was a problem hiding this comment.
@paperdave did you mean to make this UNC\\?
There was a problem hiding this comment.
i did not. current is intentional
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10281
Fixes the drive root issue, i cant find the number
small chance #10397 is also fixed