Run deinit() on CallbackJob regardless of result type #11379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I think this is probably correct. I think we manually called |
|
❌ @Jarred-Sumner, your commit has failing tests :( 🐧💪 1 failing tests Linux AARCH64
🐧🖥 1 failing tests Linux x64 baseline
🐧🖥 1 failing tests Linux x64
|
|
Are these failing tests relevant to this PR? |
|
Our CI isn't green right now but we are working on fixing that |
|
Ok, just wanted to make sure, thanks for quick reply! |
paperdave
pushed a commit
that referenced
this pull request
May 28, 2024
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes matching of callback result for Promises and forces CallbackJob to deinit regardless
Fixes #11377
Fixes #9998
probably some more
How did you verify your code works?
The only thing I could verify is repro from #11377 - this now works correctly. No tests were added (I don't know how to write proper tests for this change), but existing test suite seems fine (except some failed tests because of Windows)