Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker and websocket close fix #11635

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Worker and websocket close fix #11635

merged 6 commits into from
Jun 6, 2024

Conversation

dylan-conway
Copy link
Collaborator

@dylan-conway dylan-conway commented Jun 6, 2024

What does this PR do?

Worker:

  • set m_wasTerminated to true after sending close event
  • switch to ThreadSafeRefCounted fromRefCounted
  • remove ref count check from hasPendingActivity in worker

These changes fix bugs causing pure virtual function called! errors when using workers

Also for on_close for websockets, check if message is null instead of only length > 0 before indexing message

How did you verify your code works?

manually and existing tests

Copy link
Contributor

github-actions bot commented Jun 6, 2024

@dylan-conway, your commit has failing tests :(

💻 1 failing tests Darwin x64 baseline

  • test/js/web/streams/streams.test.js 1 failing

🪟💻 3 failing tests Windows x64 baseline

  • test/cli/install/bunx.test.ts 1 failing
  • test/integration/next-pages/test/next-build.test.ts 1 failing
  • test/js/node/watch/fs.watchFile.test.ts 3 failing

🪟💻 5 failing tests Windows x64

  • test/cli/install/bunx.test.ts 1 failing
  • test/cli/install/migration/out-of-sync.test.ts 1 failing
  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/integration/next-pages/test/dev-server.test.ts 1 failing
  • test/js/node/watch/fs.watchFile.test.ts 3 failing

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants