fix(server/tls/streams) fix onReadFile, streams, avoid shutdown on fatal errors, ensure ssl loop data and server ref count refactor #12979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @cirospaciari, your commit e01519d has 14 failures in |
cirospaciari
changed the title
cirospaciari
changed the title
cirospaciari
force-pushed
the
ciro/fix-onreadfile
branch
from
e21fd72
to
9ee70bb
Compare
cirospaciari
force-pushed
the
ciro/fix-onreadfile
branch
from
91b2b68
to
fabee65
Compare
Jarred-Sumner
requested changes
Aug 2, 2024
| @@ -1976,7 +1978,7 @@ fn NewRequestContext(comptime ssl_enabled: bool, comptime debug_mode: bool, comp | |||
| if (this.signal) |signal| { | |||
| this.signal = null; | |||
| if (this.flags.aborted and !signal.aborted()) { | |||
| const reason = JSC.WebCore.AbortSignal.createAbortError(JSC.ZigString.static("The user aborted a request"), &JSC.ZigString.Empty, this.server.globalThis); | |||
| const reason = JSC.WebCore.AbortSignal.createAbortError(JSC.ZigString.static("The user aborted a request"), &JSC.ZigString.Empty, globalThis); | |||
There was a problem hiding this comment.
As a follow-up, instead of creating this AbortError, we could probably add an enum to AbortSignal for known types of signals. Then, we can defer creating the JSValue here if it's not used.
|
@cirospaciari, CMake Warning at CMakeLists.txt:267 (message):
Expected LLVM 18 as the C++ compiler, build may fail or break at runtime.
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
9 371M 9 36.2M 0 0 33.1M 0 0:00:11 0:00:01 0:00:10 33.1M
29 371M 29 108M 0 0 51.6M 0 0:00:07 0:00:02 0:00:05 71.8M
43 371M 43 162M 0 0 52.6M 0 0:00:07 0:00:03 0:00:04 63.2M
62 371M 62 233M 0 0 57.0M 0 0:00:06 0:00:04 0:00:02 65.7M
80 371M 80 300M 0 0 58.9M 0 0:00:06 0:00:05 0:00:01 65.9M
100 371M 100 371M 0 0 60.0M 0 0:00:06 0:00:06 --:--:-- 65.8M
100 371M 100 371M 0 0 60.0M 0 0:00:06 0:00:06 --:--:-- 64.4MCommit: e01519d |
cirospaciari
changed the title
cirospaciari
force-pushed
the
ciro/fix-onreadfile
branch
from
d77531f
to
e01519d
Compare
This was referenced Aug 4, 2024
Bun.serve fetch return new Response(Bun.file("test.jpg")); sometimes returns an empty response
#7954
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?
Existing tests