Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hono example with typescript #577

Merged
merged 13 commits into from
Jul 12, 2022
Merged

Conversation

Jesse-Lucas1996
Copy link
Contributor

hono example with typescript

Copy link
Collaborator

@xhyrom xhyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete .gitignore, it's not in any example.

@xhyrom
Copy link
Collaborator

xhyrom commented Jul 11, 2022

why are you adding dom to lib?

@Jesse-Lucas1996
Copy link
Contributor Author

That's a good question, brain is fried

Copy link
Collaborator

@xhyrom xhyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

port variable is defined

examples/hono/src/index.ts Outdated Show resolved Hide resolved
Jesse-Lucas1996 and others added 2 commits July 11, 2022 23:05
Co-authored-by: Hyro <generalkubo@gmail.com>
@FinnRG FinnRG linked an issue Jul 11, 2022 that may be closed by this pull request
@Jesse-Lucas1996
Copy link
Contributor Author

Is this good to get merged in?

@Jesse-Lucas1996
Copy link
Contributor Author

Sweet, just merge in when can. I don't have write access

@FinnRG
Copy link
Collaborator

FinnRG commented Jul 12, 2022

@Jesse-Lucas1996 When I try to run bun run start, I get the following error (even if I specify the PORT env variable):

$ cd src && bun run index.ts
2 | 
3 | const app = new Hono();
4 | const home = app.get("/", (c) => {
5 |   return c.json({ message: "Hello World!" });
6 | });
7 | console.log(`Running at http://localhost:${port}`);
                                              ^
 ReferenceError: Can't find variable: port
      at /home/fg/Projects/hono-template/examples/hono/src/index.ts:7:43
Script error "start" exited with 1 status

@Jesse-Lucas1996
Copy link
Contributor Author

Ah yes I know the issue will fix soon

@Jesse-Lucas1996
Copy link
Contributor Author

@FinnRG I accidently removed code in update. All good to go now

examples/hono/package.json Outdated Show resolved Hide resolved
examples/hono/readme.md Outdated Show resolved Hide resolved
@Jesse-Lucas1996
Copy link
Contributor Author

@FinnRG and done :) nit pick away!! I love learning better or more refined ways

@FinnRG FinnRG merged commit a63a0cc into oven-sh:main Jul 12, 2022
@FinnRG
Copy link
Collaborator

FinnRG commented Jul 12, 2022

Thank you!

@Jesse-Lucas1996 Jesse-Lucas1996 deleted the hono-template branch July 12, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Hono Template
3 participants