Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove double v of version #601

Merged
merged 1 commit into from
Jul 11, 2022
Merged

docs: remove double v of version #601

merged 1 commit into from
Jul 11, 2022

Conversation

pnodet
Copy link
Contributor

@pnodet pnodet commented Jul 11, 2022

process.version is already formatted as v0.1.3

@FinnRG FinnRG merged commit ae02cad into oven-sh:main Jul 11, 2022
@pnodet pnodet deleted the patch-1 branch July 11, 2022 23:14
@moderation
Copy link

@pnxdxt @FinnRG the double v is still in the index.html of /public dir of the repo

https://github.com/oven-sh/bun/blob/main/packages/bun-landing/public/index.html#L920=

Should index.html have been updated? Is there a way to run the latest version of the landing page on a local clone?

bun dev in bun/packages/bun-landing loads in http://localhost:3000 but doesn't resolve the logos in /public correctly. bun dev --cwd public/ works as does running bun dev in bun/packages/bun-landing/public/

@moderation
Copy link

moderation commented Jul 12, 2022

I think I worked it out:
bun run build.tsx
bun dev --cwd public/
or
bun dev --cwd public/ ssr.tsx

@pnodet
Copy link
Contributor Author

pnodet commented Jul 12, 2022

@moderation Sorry I did not commit the file public/index indeed. It's the result of the build process.

@FinnRG
Copy link
Collaborator

FinnRG commented Jul 12, 2022

@moderation I looked at #280 where someone edited both the source code and the build output. There he was asked to revert the changes in the build output.

@pnodet
Copy link
Contributor Author

pnodet commented Jul 12, 2022

@FinnRG Thanks for clearing it up!

@moderation
Copy link

moderation commented Jul 12, 2022

Is there an automated job to push updates to bun.sh? It still shows the double v error

Related #584 (comment)

Screenshot_20220712-073422.png

@FinnRG
Copy link
Collaborator

FinnRG commented Jul 12, 2022

I think I worked it out: bun run build.tsx bun dev --cwd public/ or bun dev --cwd public/ ssr.tsx

@moderation No, could you create a PR with the generated html? I always get an error when executing bun build.tsx. It would also be great if you could create a new action.

@pnodet
Copy link
Contributor Author

pnodet commented Jul 12, 2022

@FinnRG Created PR #626 to generate the html

@pnodet
Copy link
Contributor Author

pnodet commented Jul 12, 2022

@FinnRG Created PR #651 to automate the landing build process

@moderation
Copy link

Awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants