Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache and main #6679

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

rohanmayya
Copy link
Contributor

@rohanmayya rohanmayya commented Oct 24, 2023

What does this PR do?

Added remaining types to Require's interface, cache and main.

Previously, in my own project, I could not do:
delete require.cache[filePath];

to clear my import cache, because cache was not a recognized type on require.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

Copy link
Contributor

@Electroid Electroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Electroid Electroid merged commit d1a7bb4 into oven-sh:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants