Support socketPath in node:http request
#9284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperdave
approved these changes
Mar 6, 2024
| }; | ||
|
|
||
| if (!!$debug) { | ||
| fetchOptions.verbose = true; |
| fetchOptions.unix = socketPath; | ||
| } | ||
|
|
||
| //@ts-ignore |
There was a problem hiding this comment.
we should not need a typescript ignore comment here. but considering the types are a mess and dont work, this can slide
|
❌ @paperdave 2 files with test failures on linux-x64:
|
|
❌ @paperdave 3 files with test failures on linux-x64-baseline: |
|
❌ @paperdave 1 files with test failures on bun-darwin-aarch64: |
|
❌ @paperdave 1 files with test failures on bun-darwin-x64: |
❌🪟 @paperdave, there are 16 test regressions on Windows x86_64
|
rglynn-dev
added a commit
to rglynn-dev/productivity-cli
that referenced
this pull request
Mar 16, 2024
Add a simple http server and client using bun. I wanted to use ipc or communicate over a unix socket, but both options do not work currently with just bun. I tried to use Bun.spawn, but that I couldn't grok how that works in the context a long running server (especially if I want logs). Might revisit that later since it feels like the correct approach at the current scope. Also there seem to be issues with resource usage of Bun.spawn currently. Then wanted to use the Bun server to communicate over a unix socket since the client and server will both be running in the same env. That works, except Bun's `fetch` implementation doesn't currently work with unix sockets (doh!). Fix has been merged on GH but not in release yet (oven-sh/bun#9284). I could revisit this approach on the next release of bun. In the end I'm just using plain old http with a really simple Bun server, no express etc since it's just overkill at this point. The upside is if this ends up scaling at all I might have a hosted server which will need to be http of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6055
Fixes #2734
How did you verify your code works?
There is a test