Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add input bun-version-file #76

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

adeherysh
Copy link
Contributor

What does this PR do?

  • feat: add input for bun-version-file

@adeherysh adeherysh changed the title feat: add input for bun-version-file feat: add input bun-version-file Apr 4, 2024
README.md Outdated
| Name | Description | Default | Examples |
| ------------------- | ------------------------------------------------------ | ----------- | ------------------------------- |
| `bun-version` | The version of Bun to download and install. | `latest` | `canary`, `1.0.0`, `1.0.x` |
| `bun-version-file` | The version of Bun to download and install from file. | `undefined` | `canary`, `1.0.0`, `1.0.x` |
Copy link
Collaborator

@xhyrom xhyrom Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong examples for bun-version-file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lemme check

@xhyrom
Copy link
Collaborator

xhyrom commented Apr 4, 2024

I'm not a big fan of x-file - it looks horrible. What about allowing files directly in bun-version instead of having two properties for the same thing?
Also this is a breaking change thus it would appear in 2.0.0.

@adeherysh
Copy link
Contributor Author

adeherysh commented Apr 9, 2024

I'm not a big fan of x-file - it looks horrible. What about allowing files directly in bun-version instead of having two properties for the same thing? Also this is a breaking change thus it would appear in 2.0.0.

Imo this config very useful for monorepo when using single workflow and have diferrent bun version between package, just create .bumrc file inside each package. And this config can make consistency bun installed version between when running in local or ci

@adeherysh adeherysh requested a review from xhyrom April 12, 2024 06:27
Copy link
Collaborator

@xhyrom xhyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'll create branch called dev because I want to do some more changes

@xhyrom xhyrom changed the base branch from main to dev April 12, 2024 06:56
@xhyrom xhyrom merged commit 3ef79fe into oven-sh:dev Apr 12, 2024
22 of 40 checks passed
@adeherysh
Copy link
Contributor Author

LGTM; I'll create branch called dev because I want to do some more changes

oke thanks @xhyrom

@xhyrom xhyrom mentioned this pull request May 7, 2024
xhyrom added a commit that referenced this pull request Jun 21, 2024
* feat: add input bun-version-file (#76)

* feat: add input for bun-version-file

* docs: update example bun version file

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* refactor: reduce read from file code

* [autofix.ci] apply automated fixes

* feat: read from all known files if not specified

* [autofix.ci] apply automated fixes

* fix: just continue if file doesnt exist

* [autofix.ci] apply automated fixes

* fix: return output if found version

* [autofix.ci] apply automated fixes

* fix: make whitespace in .tool-versions optional

* [autofix.ci] apply automated fixes

* log loglog

* [autofix.ci] apply automated fixes

* log log log

* [autofix.ci] apply automated fixes

* better warnings, fix ci failing

* [autofix.ci] apply automated fixes

* feat: log obtained version

* [autofix.ci] apply automated fixes

* build: bump version

* [autofix.ci] apply automated fixes

* fix: add .zip extension if it's not present

Workaround for actions/toolkit#1179

Fixes #79

* [autofix.ci] apply automated fixes

* docs: add comment for easier understanding

* ci: more readable version

* ci: match name

* docs: add package.json and .tool-versions to bun-version-file examples

* ci: add cache test

* ci: install another pkg for cache test

* ci: install more pkgs for cache test

* ci: block all trusted deps in cache test

* ci: more deps for cache test

* ci: cache test should cache

* refactor: dont try all files if not defined

* [autofix.ci] apply automated fixes

* ci: remove cache test

* feat: support .bunrc

* [autofix.ci] apply automated fixes

* refactor: .bun-version instead .bunrc

* [autofix.ci] apply automated fixes

* feat: add bun paths and url to output

Fixes #81

* [autofix.ci] apply automated fixes

* ci: test for .bun-version

* feat: make .bun-version as default in bun-version-file

* ci: remove cache before test

* ci: remove cache before test

* ci: remove cache before test

* ci: remove cache before test

---------

Co-authored-by: Ade Hery Shopyan <51158020+adeherysh@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@michaelmior
Copy link

Is this supposed to be called .bumrc by default and not .bunrc?

@Jarred-Sumner
Copy link
Contributor

Is this supposed to be called .bumrc by default and not .bunrc?

It is not supposed to be called .bumrc or .bunrc

@michaelmior
Copy link

@Jarred-Sumner The example given is .bumrc, so I'm confused by your comment. I was just wondering if there was a typo that should be corrected.

@Jarred-Sumner
Copy link
Contributor

Yep, thanks for flagging

thm-automation bot referenced this pull request in theoremlp/prettier-standalone Jun 24, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` |

---

### Release Notes

<details>
<summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary>

### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2)

[Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2)

`oven-sh/setup-bun` is the github action for setting up Bun.

This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81))

For more information, see [https://github.com/oven-sh/setup-bun/pull/76](https://togithub.com/oven-sh/setup-bun/pull/76) by [@&#8203;adeherysh](https://togithub.com/adeherysh) and [https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80) by [@&#8203;xHyroM](https://togithub.com/xHyroM) 🎉

**Full Changelog**: oven-sh/setup-bun@v1...v2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday after 9am before 5pm" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
@xhyrom
Copy link
Collaborator

xhyrom commented Jun 24, 2024

@Jarred-Sumner The example given is .bumrc, so I'm confused by your comment. I was just wondering if there was a typo that should be corrected.

Fixed in #86, thanks for flagging :)

kodiakhq bot referenced this pull request in mheob/config Jul 12, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` |

---

### Release Notes

<details>
<summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary>

### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2)

[Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2)

`oven-sh/setup-bun` is the github action for setting up Bun.

This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81))

For more information, see [https://github.com/oven-sh/setup-bun/pull/76](https://togithub.com/oven-sh/setup-bun/pull/76) by [@&#8203;adeherysh](https://togithub.com/adeherysh) and [https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80) by [@&#8203;xHyroM](https://togithub.com/xHyroM) 🎉

**Full Changelog**: oven-sh/setup-bun@v1...v2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Wednesday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/mheob/config).
fbjork referenced this pull request in grafbase/grafbase Sep 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [oven-sh/setup-bun](https://redirect.github.com/oven-sh/setup-bun) |
action | major | `v1` -> `v2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary>

###
[`v2`](https://redirect.github.com/oven-sh/setup-bun/releases/tag/v2)

[Compare
Source](https://redirect.github.com/oven-sh/setup-bun/compare/v1...v2)

`oven-sh/setup-bun` is the github action for setting up Bun.

This release introduces support for the `bun-version-file` option, fixes
[https://github.com/oven-sh/setup-bun/issues/79](https://redirect.github.com/oven-sh/setup-bun/issues/79),
and adds bun paths & urls to the output
([https://github.com/oven-sh/setup-bun/issues/81](https://redirect.github.com/oven-sh/setup-bun/issues/81))

For more information, see
[https://github.com/oven-sh/setup-bun/pull/76](https://redirect.github.com/oven-sh/setup-bun/pull/76)
by [@&#8203;adeherysh](https://redirect.github.com/adeherysh) and
[https://github.com/oven-sh/setup-bun/pull/80](https://redirect.github.com/oven-sh/setup-bun/pull/80)
by [@&#8203;xHyroM](https://redirect.github.com/xHyroM) 🎉

**Full Changelog**: oven-sh/setup-bun@v1...v2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/grafbase/grafbase).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants