Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v2.0 🎉 #80

Merged
merged 49 commits into from
Jun 21, 2024
Merged

release: v2.0 🎉 #80

merged 49 commits into from
Jun 21, 2024

Conversation

xhyrom
Copy link
Collaborator

@xhyrom xhyrom commented May 7, 2024

thanks for #76

Fixes #79
Fixes #81

adeherysh and others added 2 commits April 12, 2024 22:17
* feat: add input for bun-version-file

* docs: update example bun version file

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@xhyrom xhyrom changed the title release: 2.0 🎉 release: v2.0 🎉 May 7, 2024
@dloetzke
Copy link

Oh okay, that makes sense - thanks for adding .bunrc as a second option then. :)

@Jarred-Sumner
Copy link
Contributor

Jarred-Sumner commented May 21, 2024

Why .bunrc when bunfig.toml exists? If the goal is to just specify the bun version and no further config, why not .bun-version instead of .bunrc?

@xhyrom
Copy link
Collaborator Author

xhyrom commented May 22, 2024

Why .bunrc when bunfig.toml exists? If the goal is to just specify the bun version and no further config, why not .bun-version instead of .bunrc?

Sure, that sounds better, we can do that ;)

@dloetzke
Copy link

Could it be a good idea to always check for a .bun-version file and use the version from there, even without any bun-version-file input being passed?
I don't think anyone would have such a file and not want the version in there to be used.

@xhyrom
Copy link
Collaborator Author

xhyrom commented May 27, 2024

Could it be a good idea to always check for a .bun-version file and use the version from there, even without any bun-version-file input being passed? I don't think anyone would have such a file and not want the version in there to be used.

That's true but it leads to hidden behaviour and I'm not sure if that's what we want. Probably can be done by setting bun-version-file to .bun-version by default

@xhyrom xhyrom linked an issue May 27, 2024 that may be closed by this pull request
@dloetzke
Copy link

That's true but it leads to hidden behaviour and I'm not sure if that's what we want. Probably can be done by setting bun-version-file to .bun-version by default

Setting it as default might make sense, though then it'd be better to check for a bun-version input first/with priority (not sure which input would override the other one right now).
That would only cause hidden behavior if there is no bun-version nor bun-version-file input, but a .bun-version file exists.

@xhyrom
Copy link
Collaborator Author

xhyrom commented Jun 17, 2024

Ready to merge, tomorrow

@xhyrom xhyrom merged commit ef00e4a into main Jun 21, 2024
29 of 41 checks passed
vladfrangu referenced this pull request in apify/crawlee Jun 24, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action |
major | `v1` -> `v2` |

---

### Release Notes

<details>
<summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary>

### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2)

[Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2)

`oven-sh/setup-bun` is the github action for setting up Bun.

This release introduces support for the `bun-version-file` option, fixes
[https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79),
and adds bun paths & urls to the output
([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81))

For more information, see
[https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80)
by [@&#8203;xHyroM](https://togithub.com/xHyroM) 🎉

**Full Changelog**: oven-sh/setup-bun@v1...v2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/apify/crawlee).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@ArnaudBarre
Copy link

A small note in the release on why you decided this is major would be appreciated

@Jarred-Sumner
Copy link
Contributor

A small note in the release on why you decided this is major would be appreciated

I’m curious too

thm-automation bot referenced this pull request in theoremlp/prettier-standalone Jun 24, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` |

---

### Release Notes

<details>
<summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary>

### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2)

[Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2)

`oven-sh/setup-bun` is the github action for setting up Bun.

This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81))

For more information, see [https://github.com/oven-sh/setup-bun/pull/76](https://togithub.com/oven-sh/setup-bun/pull/76) by [@&#8203;adeherysh](https://togithub.com/adeherysh) and [https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80) by [@&#8203;xHyroM](https://togithub.com/xHyroM) 🎉

**Full Changelog**: oven-sh/setup-bun@v1...v2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday after 9am before 5pm" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
@xhyrom
Copy link
Collaborator Author

xhyrom commented Jun 24, 2024

A small note in the release on why you decided this is major would be appreciated

This version changes the behavior when selecting which version to install. When you have:

- uses: oven-sh/setup-bun@v2

it'll now look to see if there's a .bun-version and if not, it'll install the latest version. Previously it installed latest version without checking this file. I know it's probably pointless but I was planning a few more breaking changes that didn't happen, and then I didn't think about it anymore. My apologies.

fbjork referenced this pull request in grafbase/grafbase Jun 25, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action |
major | `v1` -> `v2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary>

### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2)

[Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2)

`oven-sh/setup-bun` is the github action for setting up Bun.

This release introduces support for the `bun-version-file` option, fixes
[https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79),
and adds bun paths & urls to the output
([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81))

For more information, see
[https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80)
by [@&#8203;xHyroM](https://togithub.com/xHyroM) 🎉

**Full Changelog**: oven-sh/setup-bun@v1...v2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/grafbase/grafbase).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
kodiakhq bot referenced this pull request in mheob/config Jul 12, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [oven-sh/setup-bun](https://togithub.com/oven-sh/setup-bun) | action | major | `v1` -> `v2` |

---

### Release Notes

<details>
<summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary>

### [`v2`](https://togithub.com/oven-sh/setup-bun/releases/tag/v2)

[Compare Source](https://togithub.com/oven-sh/setup-bun/compare/v1...v2)

`oven-sh/setup-bun` is the github action for setting up Bun.

This release introduces support for the `bun-version-file` option, fixes [https://github.com/oven-sh/setup-bun/issues/79](https://togithub.com/oven-sh/setup-bun/issues/79), and adds bun paths & urls to the output ([https://github.com/oven-sh/setup-bun/issues/81](https://togithub.com/oven-sh/setup-bun/issues/81))

For more information, see [https://github.com/oven-sh/setup-bun/pull/76](https://togithub.com/oven-sh/setup-bun/pull/76) by [@&#8203;adeherysh](https://togithub.com/adeherysh) and [https://github.com/oven-sh/setup-bun/pull/80](https://togithub.com/oven-sh/setup-bun/pull/80) by [@&#8203;xHyroM](https://togithub.com/xHyroM) 🎉

**Full Changelog**: oven-sh/setup-bun@v1...v2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Wednesday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/mheob/config).
@xhyrom xhyrom deleted the dev branch July 15, 2024 18:10
fbjork referenced this pull request in grafbase/grafbase Sep 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [oven-sh/setup-bun](https://redirect.github.com/oven-sh/setup-bun) |
action | major | `v1` -> `v2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>oven-sh/setup-bun (oven-sh/setup-bun)</summary>

###
[`v2`](https://redirect.github.com/oven-sh/setup-bun/releases/tag/v2)

[Compare
Source](https://redirect.github.com/oven-sh/setup-bun/compare/v1...v2)

`oven-sh/setup-bun` is the github action for setting up Bun.

This release introduces support for the `bun-version-file` option, fixes
[https://github.com/oven-sh/setup-bun/issues/79](https://redirect.github.com/oven-sh/setup-bun/issues/79),
and adds bun paths & urls to the output
([https://github.com/oven-sh/setup-bun/issues/81](https://redirect.github.com/oven-sh/setup-bun/issues/81))

For more information, see
[https://github.com/oven-sh/setup-bun/pull/76](https://redirect.github.com/oven-sh/setup-bun/pull/76)
by [@&#8203;adeherysh](https://redirect.github.com/adeherysh) and
[https://github.com/oven-sh/setup-bun/pull/80](https://redirect.github.com/oven-sh/setup-bun/pull/80)
by [@&#8203;xHyroM](https://redirect.github.com/xHyroM) 🎉

**Full Changelog**: oven-sh/setup-bun@v1...v2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/grafbase/grafbase).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants