Skip to content

Commit 9232e94

Browse files
authored
Merge pull request #259 from casskir/master
Add description field to custom-scalar type
2 parents ac4e139 + 1301169 commit 9232e94

File tree

5 files changed

+11
-3
lines changed

5 files changed

+11
-3
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ matrix:
2626
- php: 7.2
2727
env: SYMFONY_VERSION=3.3.*
2828
- php: 7.2
29-
env: SYMFONY_VERSION=3.4.* GRAPHQLPHP_VERSION=0.10.0 DEPENDENCIES=dev
29+
env: SYMFONY_VERSION=3.4.*
3030
- php: 7.2
3131
env: SYMFONY_VERSION=4.0.* TEST_COVERAGE=true
3232
- php: 7.2

Config/CustomScalarTypeDefinition.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ public function getDefinition()
1414
$node
1515
->children()
1616
->append($this->nameSection())
17+
->append($this->descriptionSection())
1718
->variableNode('serialize')->isRequired()->end()
1819
->variableNode('parseValue')->isRequired()->end()
1920
->variableNode('parseLiteral')->isRequired()->end()

Tests/Functional/App/config/customScalar/mapping/Query.types.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
DateTime:
22
type: custom-scalar
33
config:
4+
description: "The DateTime type"
45
serialize: ["Overblog\\GraphQLGenerator\\Tests\\DateTimeType", "serialize"]
56
parseValue: ["Overblog\\GraphQLGenerator\\Tests\\DateTimeType", "parseValue"]
67
parseLiteral: ["Overblog\\GraphQLGenerator\\Tests\\DateTimeType", "parseLiteral"]

Tests/Functional/Type/CustomScalarTest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,10 @@ public function testDateTimeTypeParseValue()
3030
];
3131
$this->assertGraphQL($query, $expected);
3232
}
33+
34+
public function testDateTimeTypeDescription()
35+
{
36+
$dateTimeType = static::$kernel->getContainer()->get('overblog_graphql.type_resolver')->resolve('DateTime');
37+
$this->assertEquals('The DateTime type', $dateTimeType->description);
38+
}
3339
}

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@
3131
"require": {
3232
"php": ">=5.6",
3333
"doctrine/doctrine-cache-bundle": "^1.2",
34-
"overblog/graphql-php-generator": "^0.6.0",
34+
"overblog/graphql-php-generator": "^0.7.0",
3535
"symfony/cache": "^3.1 || ^4.0",
3636
"symfony/config": "^3.1 || ^4.0",
3737
"symfony/dependency-injection": "^3.1 || ^4.0",
3838
"symfony/expression-language": "^3.1 || ^4.0",
3939
"symfony/framework-bundle": "^3.1 || ^4.0",
4040
"symfony/options-resolver": "^3.1 || ^4.0",
4141
"symfony/property-access": "^3.1 || ^4.0",
42-
"webonyx/graphql-php": "^0.10.0 || ^0.11.0"
42+
"webonyx/graphql-php": "^0.11.2"
4343
},
4444
"suggest": {
4545
"nelmio/cors-bundle": "For more flexibility when using CORS prefight",

0 commit comments

Comments
 (0)