Fix/#202 ssl config not parsed #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darksaid98
reviewed
Oct 20, 2023
src/config.ts
Outdated
| } catch {} | ||
| } catch (err) { | ||
| console.log( | ||
| `^3Unable to parse ${key} configuration (${err})!^0` |
There was a problem hiding this comment.
Suggested change
| `^3Unable to parse ${key} configuration (${err})!^0` | |
| `^3Failed to parse property '${key}' in configuration (${err})!^0` |
There was a problem hiding this comment.
Super nitpicky on my end, but other than that it looks good. Nice catch.
There was a problem hiding this comment.
Reworded as per notice and pushed changes :)
darksaid98
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #202 issue
See #202 (comment) for more details on reason for opening it