fix, cli limit get-changes status enum (#2755)

<!-- CURSOR_SUMMARY -->
> [!NOTE]
> Restricts get-change --status to allowed enums with validation and
adds unit tests.
>
> - **CLI**:
> - `GetChange`: Validate `--status` via new `validateChangeStatus` and
pass the parsed `sdp.ChangeStatus` to `getChangeUUIDAndCheckStatus`.
> - `validateChangeStatus`: Accepts only `CHANGE_STATUS_DEFINING`,
`CHANGE_STATUS_HAPPENING`, `CHANGE_STATUS_DONE`; returns `flagError` for
invalid values.
> - **Tests**:
> - Add `changes_get_change_test.go` covering valid/invalid `--status`
inputs and asserting `flagError` on failures.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
dd7cb9061f2af5f9810cba4d024b9f0bd5efff90. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

check the linear ticket to see this issue in honeycomb. but our
customers are filtering on statuses we do not use, therefore they will
be getting confusing messages about not finding changes that are in
ChangeStatus_CHANGE_STATUS_UNSPECIFIED(which is no longer used) or
CHANGE_STATUS_PROCESSING(not used anywhere).

<img width="2841" height="1817" alt="image"
src="https://github.com/user-attachments/assets/0e646e4b-493f-46cc-bc83-18d873f3f515"
/>
GitOrigin-RevId: 686ee76106f8ff308ece2f50072f3a294c1dafb3

Author: tphoney

cmd/changes_get_change.go

@@ -27,6 +27,12 @@ func GetChange(cmd *cobra.Command, args []string) error {
 
 	app := viper.GetString("app")
 
+	// Validate status flag
+	status, err := validateChangeStatus(viper.GetString("status"))
+	if err != nil {
+		return err
+	}
+
 	riskLevels := []sdp.Risk_Severity{}
 	for _, level := range viper.GetStringSlice("risk-levels") {
 		switch level {
@@ -52,7 +58,7 @@ func GetChange(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	changeUuid, err := getChangeUUIDAndCheckStatus(ctx, oi, sdp.ChangeStatus(sdp.ChangeStatus_value[viper.GetString("status")]), viper.GetString("ticket-link"), true)
+	changeUuid, err := getChangeUUIDAndCheckStatus(ctx, oi, status, viper.GetString("ticket-link"), true)
 	if err != nil {
 		return loggedError{
 			err:     err,
@@ -148,6 +154,30 @@ fetch:
 	return nil
 }
 
+// validateChangeStatus validates that the provided status string is a valid ChangeStatus
+func validateChangeStatus(statusStr string) (sdp.ChangeStatus, error) {
+	// Define valid status values (excluding UNSPECIFIED and PROCESSING as they are not typically used)
+	validStatuses := map[string]sdp.ChangeStatus{
+		"CHANGE_STATUS_DEFINING":  sdp.ChangeStatus_CHANGE_STATUS_DEFINING,
+		"CHANGE_STATUS_HAPPENING": sdp.ChangeStatus_CHANGE_STATUS_HAPPENING,
+		"CHANGE_STATUS_DONE":      sdp.ChangeStatus_CHANGE_STATUS_DONE,
+	}
+
+	if status, exists := validStatuses[statusStr]; exists {
+		return status, nil
+	}
+
+	// Build list of valid status names for error message
+	validNames := make([]string, 0, len(validStatuses))
+	for name := range validStatuses {
+		validNames = append(validNames, name)
+	}
+
+	return sdp.ChangeStatus_CHANGE_STATUS_UNSPECIFIED, flagError{
+		fmt.Sprintf("invalid --status value '%s', allowed values are: %s", statusStr, strings.Join(validNames, ", ")),
+	}
+}
+
 func init() {
 	changesCmd.AddCommand(getChangeCmd)
 	addAPIFlags(getChangeCmd)

cmd/changes_get_change_test.go

@@ -0,0 +1,91 @@
+package cmd
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/overmindtech/cli/sdp-go"
+)
+
+func TestValidateChangeStatus(t *testing.T) {
+	tests := []struct {
+		name        string
+		statusStr   string
+		expected    sdp.ChangeStatus
+		expectError bool
+	}{
+		{
+			name:        "valid defining status",
+			statusStr:   "CHANGE_STATUS_DEFINING",
+			expected:    sdp.ChangeStatus_CHANGE_STATUS_DEFINING,
+			expectError: false,
+		},
+		{
+			name:        "valid happening status",
+			statusStr:   "CHANGE_STATUS_HAPPENING",
+			expected:    sdp.ChangeStatus_CHANGE_STATUS_HAPPENING,
+			expectError: false,
+		},
+		{
+			name:        "valid done status",
+			statusStr:   "CHANGE_STATUS_DONE",
+			expected:    sdp.ChangeStatus_CHANGE_STATUS_DONE,
+			expectError: false,
+		},
+		{
+			name:        "invalid status - empty string",
+			statusStr:   "",
+			expected:    sdp.ChangeStatus_CHANGE_STATUS_UNSPECIFIED,
+			expectError: true,
+		},
+		{
+			name:        "invalid status - random string",
+			statusStr:   "INVALID_STATUS",
+			expected:    sdp.ChangeStatus_CHANGE_STATUS_UNSPECIFIED,
+			expectError: true,
+		},
+		{
+			name:        "invalid status - unspecified",
+			statusStr:   "CHANGE_STATUS_UNSPECIFIED",
+			expected:    sdp.ChangeStatus_CHANGE_STATUS_UNSPECIFIED,
+			expectError: true,
+		},
+		{
+			name:        "invalid status - processing",
+			statusStr:   "CHANGE_STATUS_PROCESSING",
+			expected:    sdp.ChangeStatus_CHANGE_STATUS_UNSPECIFIED,
+			expectError: true,
+		},
+		{
+			name:        "invalid status - lowercase",
+			statusStr:   "change_status_defining",
+			expected:    sdp.ChangeStatus_CHANGE_STATUS_UNSPECIFIED,
+			expectError: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result, err := validateChangeStatus(tt.statusStr)
+
+			if tt.expectError {
+				if err == nil {
+					t.Errorf("validateChangeStatus() expected error but got none")
+				}
+				// Check that it returns a flagError
+				var fError flagError
+				if !errors.As(err, &fError) {
+					t.Errorf("validateChangeStatus() expected flagError but got %T", err)
+				}
+			} else {
+				if err != nil {
+					t.Errorf("validateChangeStatus() unexpected error: %v", err)
+				}
+			}
+
+			if result != tt.expected {
+				t.Errorf("validateChangeStatus() = %v, expected %v", result, tt.expected)
+			}
+		})
+	}
+}