Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the cost of reflection in tight loops #26

Merged
merged 1 commit into from
May 24, 2015

Conversation

josephwilk
Copy link
Contributor

What?

Improve the performance of the draw fn by avoiding the cost of reflection by using type hints.
Might only be a little bump in performance but worthy of saving were possible.

I've also turned reflection warnings on, so its easier to spot reflection costs within highly repeatable code chunks.

@rogerallen
Copy link
Member

Thanks. Will give this a checkout on the weekend.

rogerallen added a commit that referenced this pull request May 24, 2015
Avoid the cost of reflection in tight loops
@rogerallen rogerallen merged commit 457a484 into overtone:master May 24, 2015
@rogerallen
Copy link
Member

Thank you, Joseph. This is a nice thing to enable and be aware of. I'll look into getting rid of all the warnings as a code-cleanliness issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants