[Docs #46] add megamenu #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add keys, adjust desktop menu breakpoint tighten up mobile nav a little netlify update readme remove localStorage flag tighten up desktop nav PR cleanup remove netlify file
samrichca
force-pushed
the
docs-050-menu
branch
from
4ab4e71
to
d5091cb
Compare
9 tasks
anncatton
reviewed
Sep 25, 2020
src/components/Footer/index.js
Outdated
| src={logo} | ||
| style={{ maxHeight: '100px', paddingRight: '32px' }} | ||
| /> | ||
| <img src={logo} /> |
src/components/Footer/index.js
Outdated
| @@ -172,11 +177,11 @@ const Footer = () => { | |||
| </div> | |||
| <div className="container netlify-badge"> | |||
| <a target="_blank" href="https://www.netlify.com"> | |||
| <img src="https://www.netlify.com/img/global/badges/netlify-color-bg.svg"/> | |||
| <img src="https://www.netlify.com/img/global/badges/netlify-color-bg.svg" /> | |||
src/constants.js
Outdated
| @@ -0,0 +1 @@ | |||
| export const SHOW_DOCS = true; | |||
There was a problem hiding this comment.
is this going to come from an env/config at some point?
There was a problem hiding this comment.
yup, it'll be environment variables - you'll see documentation in development but not production
| ol > li:before { /* the only way to remove "." from an OL ?! */ | ||
| content: counter(customlistcounter) " "; | ||
| ol > li:before { | ||
| /* the only way to remove "." from an OL ?! */ |
There was a problem hiding this comment.
i think this can just be list-style: none ?
There was a problem hiding this comment.
nah, it's an ordered list, and the original developer wanted to change 1. to 1 (no period)
| @@ -0,0 +1,29 @@ | |||
| $blue-bg: #6ac3e8; | |||
There was a problem hiding this comment.
thank you for colour vars!! at some point we should standardize the names across our products :)
There was a problem hiding this comment.
agreed! I wasn't sure what to call most of these, but wanted the vars anyways. we can standardize any time.
anncatton
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: overture-stack/roadmap#46
Description:
requires SHOW_DOCS feature flag (not merged yet)