Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs #46] add megamenu #77

Merged
merged 42 commits into from
Oct 28, 2020
Merged

[Docs #46] add megamenu #77

merged 42 commits into from
Oct 28, 2020

Conversation

samrichca
Copy link
Member

@samrichca samrichca commented Sep 8, 2020

Ticket: overture-stack/roadmap#46

Description:

  • Convert Products menu to a reusable megamenu
  • CSS changes (add borders/shadows to megamenu, reduce padding/margins in nav to accommodate new items)
  • Add a constant for showing/hiding documentation section (this will become an environment variable in the next ticket)
  • Collect all colours in a SCSS file
  • Changed text of the header Github button
  • Changed styling of header Github & Slack buttons
  • Add Documentation to menus
  • Update readme

requires SHOW_DOCS feature flag (not merged yet)

@samrichca samrichca changed the title [Docs #50] add megamenu [Docs #46] add megamenu Sep 17, 2020
@samrichca samrichca marked this pull request as ready for review September 17, 2020 14:27
add keys, adjust desktop menu breakpoint

tighten up mobile nav a little

netlify

update readme

remove localStorage flag

tighten up desktop nav

PR cleanup

remove netlify file
@samrichca samrichca requested review from anncatton and removed request for rtisma September 18, 2020 15:14
Copy link

@anncatton anncatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments :)

src={logo}
style={{ maxHeight: '100px', paddingRight: '32px' }}
/>
<img src={logo} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an alt attr

@@ -172,11 +177,11 @@ const Footer = () => {
</div>
<div className="container netlify-badge">
<a target="_blank" href="https://www.netlify.com">
<img src="https://www.netlify.com/img/global/badges/netlify-color-bg.svg"/>
<img src="https://www.netlify.com/img/global/badges/netlify-color-bg.svg" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt attr

src/constants.js Outdated
@@ -0,0 +1 @@
export const SHOW_DOCS = true;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this going to come from an env/config at some point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, it'll be environment variables - you'll see documentation in development but not production

ol > li:before { /* the only way to remove "." from an OL ?! */
content: counter(customlistcounter) " ";
ol > li:before {
/* the only way to remove "." from an OL ?! */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this can just be list-style: none ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, it's an ordered list, and the original developer wanted to change 1. to 1 (no period)

@@ -0,0 +1,29 @@
$blue-bg: #6ac3e8;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for colour vars!! at some point we should standardize the names across our products :)

Copy link
Member Author

@samrichca samrichca Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed! I wasn't sure what to call most of these, but wanted the vars anyways. we can standardize any time.

Copy link

@anncatton anncatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge once the SHOW_DOCS feature flag is set up!

@samrichca samrichca merged commit 35848f6 into develop Oct 28, 2020
@samrichca samrichca deleted the docs-050-menu branch October 28, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants