-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (engine): status on all services, api too #2572
Conversation
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
engine/api/services.go
Outdated
oldSrv, errOldSrv := repo.FindByName(srv.Name) | ||
if errOldSrv != nil && errOldSrv != sdk.ErrNotFound { | ||
log.Error("serviceAPIHeartbeat:%v", errOldSrv) | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing repo.Rollback() ?
engine/hatchery/marathon/marathon.go
Outdated
@@ -14,8 +14,11 @@ import ( | |||
|
|||
"github.com/facebookgo/httpcontrol" | |||
"github.com/gambol99/go-marathon" | |||
"github.com/gorilla/mux" | |||
"github.com/ovh/cds/sdk/namesgenerator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to the good import block
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add integration tests to check:
the status ,
list of started services,
etc.
hatcheries -> services (old heartbeat on hatchery is keep for now)
api -> service too
status is stored in service table
so, cdsctl admin services status [-t]
with type :
-t, --type string Filter service by type: api, hatchery, hook, repository, vcs