feat (worker): cds.semver review #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on a tag: git.describe+cds.version example: 0.13.0+cds.888, where 888 is the cds.version on a non-tag: 0.31.1-1-g3dfdc2031+cds.888 notice that 0.31.1-1-g3dfdc2031 is considered as a valid semver Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
cds.semver should not be used as a tag name example: 0.31.1-1-g3dfdc2031, we probably don't want to create a tag with that
sguiheux
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on a tag: git.describe+cds.version
example: 0.13.0+cds.888, where 888 is the cds.version
on a non-tag: 0.31.1-1-g3dfdc2031+cds.888
notice that 0.31.1-1-g3dfdc2031 is considered as a valid semver
Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com