fix(ui): better label modals #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close #3286 Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
bnjjj
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
yesnault
requested changes
Sep 10, 2018
ui/src/assets/i18n/fr.json
Outdated
| @@ -587,6 +587,7 @@ | |||
| "project_variable_list_title": "Liste des variables du projet: ", | |||
| "project_variable_form_title": "Ajouter une nouvelle variable: ", | |||
| "project_workflows_list": "Liste des workflows du projet : ", | |||
| "project_label_no": "Il n'y a pas de labels configurés dans ce projet.", | |||
There was a problem hiding this comment.
"Il n'y a pas de label configuré dans ce projet."
ui/src/assets/i18n/en.json
Outdated
| @@ -587,6 +587,7 @@ | |||
| "project_variable_list_title": "List of project variables: ", | |||
| "project_variable_form_title": "Add a new variable: ", | |||
| "project_workflows_list": "List of workflows in the project: ", | |||
| "project_label_no": "There is no labels configured in this project.", | |||
fsamin
approved these changes
Sep 10, 2018
richardlt
approved these changes
Sep 10, 2018
close #3286 Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
yesnault
approved these changes
Sep 11, 2018
bnjjj
added a commit
that referenced
this pull request
Sep 13, 2018
* fix(ui): better label modals close #3286 Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
This was referenced Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3286
Signed-off-by: Benjamin Coenen benjamin.coenen@corp.ovh.com
@ovh/cds