Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrony and ntp checks should skip if package is not installed #117

Closed
sblaisot opened this issue Oct 14, 2021 · 3 comments · Fixed by #120
Closed

chrony and ntp checks should skip if package is not installed #117

sblaisot opened this issue Oct 14, 2021 · 3 comments · Fixed by #120
Assignees
Labels

Comments

@sblaisot
Copy link
Contributor

2.2.1.3_configure_chrony consider check failed if chrony package is not installed. However, CIS benchmark §2.2.1.3 is only related to chrony proper configuration and clearly states:

This recommendation only applies if chrony is in use on the system.

so the check should be skipped if package is not installed instead of failing (like when grub is not in use for test 1.5.1_bootloader_ownership

same should apply to 2.2.1.4_configure_ntp if ntp is not instaled

2.2.1.3_configure_chrony  [ KO ] chrony is not installed!
2.2.1.3_configure_chrony  [ KO ] Check Failed
@ThibaultDewailly
Copy link
Collaborator

Hello Sebastien,

We currently disable the check on machines via configuration file where chrony (for instance) is not installed on the machine, wouldn't this solution work for you ?

@sblaisot
Copy link
Contributor Author

sblaisot commented Oct 15, 2021

yes, that would work.
However, on the other side, CIS benchmark clearly states that the recommandation only apply if chrony (resp. ntp) is in use so default config should skip if not installed I think.
I will try to publish a pull request.

@sblaisot
Copy link
Contributor Author

sblaisot commented Oct 16, 2021

enforcing either chrony or ntp is installed could be added as a 99.x check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants