Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Rollup Configuration - Inject translation imports #1699

Closed
antleblanc opened this issue Nov 4, 2019 · 0 comments · Fixed by #4022
Closed

Component Rollup Configuration - Inject translation imports #1699

antleblanc opened this issue Nov 4, 2019 · 0 comments · Fixed by #4022
Assignees
@antleblanc
Labels
enhancement New feature or request

Comments

@antleblanc
Copy link
Member

antleblanc commented Nov 4, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
By the past we used to manage translation with the default XML format.

We are now using the JSON format to be compatible with angular-translate.

Describe the solution you'd like
Introduce a BREAKING CHANGE to set the default format as json here:
https://github.com/ovh/manager/blob/master/packages/manager/tools/component-rollup-config/src/plugins/translation-utils.ts#L93

Describe alternatives you've considered
None.

Additional context
None.
@antleblanc antleblanc added the enhancement New feature or request label Nov 4, 2019
@antleblanc antleblanc self-assigned this Nov 4, 2019
@antleblanc antleblanc pinned this issue Feb 9, 2020
@antleblanc antleblanc linked a pull request Nov 13, 2020 that will close this issue
Feat/translation inject #4022
Merged
@antleblanc antleblanc mentioned this issue Nov 13, 2020
Merged
antleblanc pushed a commit that referenced this issue Nov 20, 2020
@frenautvh @antleblanc
feat(plugins): rewrite translation inject and drop xml support
9b8dbbf 
Fixes #1699

Signed-off-by: frenauvh <florian.renaut@corp.ovh.com>

BREAKING CHANGE: translation xml files are not supported anymore
@antleblanc antleblanc unpinned this issue Nov 25, 2020
fchabrolle pushed a commit that referenced this issue Dec 1, 2020
@frenautvh @fchabrolle
feat(plugins): rewrite translation inject and drop xml support
5dbfe0d 
Fixes #1699

Signed-off-by: frenauvh <florian.renaut@corp.ovh.com>

BREAKING CHANGE: translation xml files are not supported anymore

Signed-off-by: Fabien Chabrolle <fabien.chabrolle@corp.ovh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antleblanc antleblanc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/translation inject ovh/manager
1 participant
@antleblanc