Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rancher): add request tagger on each request page #11282

Merged
merged 1 commit into from
May 23, 2024
Merged

feat(rancher): add request tagger on each request page #11282

merged 1 commit into from
May 23, 2024

Conversation

lionel95200x
Copy link
Contributor

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #14030
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add Request tagger on each page for Rancher

Related

@lionel95200x lionel95200x requested review from a team as code owners March 25, 2024 15:09
@github-actions github-actions bot added the feature New feature label Mar 25, 2024
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch from 0ee5c94 to 7cac8c7 Compare March 25, 2024 15:13
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch 2 times, most recently from 5b3c34d to f88a9c1 Compare March 28, 2024 15:57
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Apr 4, 2024
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch from f88a9c1 to 0885225 Compare April 8, 2024 07:25
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Apr 8, 2024
chipp972
chipp972 previously approved these changes Apr 8, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Apr 15, 2024
@lionel95200x lionel95200x changed the base branch from master to develop April 18, 2024 07:37
@lionel95200x lionel95200x dismissed stale reviews from aboungnaseng-ovhcloud and chipp972 April 18, 2024 07:37

The base branch was changed.

@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch from 0885225 to 01c6759 Compare April 18, 2024 08:33
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Apr 18, 2024
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch from 01c6759 to b759c04 Compare April 18, 2024 09:32
chipp972
chipp972 previously approved these changes Apr 18, 2024
View reviewed changes
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch from b759c04 to 8ed80f4 Compare May 2, 2024 12:25
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch 3 times, most recently from 82efb11 to 2d63c77 Compare May 10, 2024 09:03
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 16, 2024
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch from 2d63c77 to 65c426d Compare May 16, 2024 13:27
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch from 65c426d to e8315c0 Compare May 16, 2024 13:30
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label May 16, 2024
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch 2 times, most recently from 103596c to 480854a Compare May 23, 2024 12:10
anooparveti
anooparveti previously approved these changes May 23, 2024
View reviewed changes
packages/manager/apps/pci-rancher/src/pages/layout.tsx Outdated Show resolved Hide resolved
aboungnaseng-ovhcloud
aboungnaseng-ovhcloud reviewed May 23, 2024
View reviewed changes
packages/manager/apps/pci-rancher/src/pages/layout.tsx
useEffect(() => {
const [match] = matches.slice(-1) as Match[];
// We cannot type properly useMatches cause it's not support type inference or passing specific type https://github.com/remix-run/react-router/discussions/10902
defineCurrentPage(`app.pci-rancher.${match?.handle?.tracking?.pageName}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lionel95200x
feat(rancher): add request tagger on each request page
82f0e90 
ref: MANAGER-14030

Signed-off-by: Lio <lionel95200@gmail.com>
@lionel95200x lionel95200x force-pushed the feat/MANAGER-14030-add-request-tagger-rancher branch from 480854a to 82f0e90 Compare May 23, 2024 12:49
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@anooparveti anooparveti merged commit 4af99f8 into develop May 23, 2024
15 checks passed
@anooparveti anooparveti deleted the feat/MANAGER-14030-add-request-tagger-rancher branch May 23, 2024 13:25
@ghyenne ghyenne mentioned this pull request May 23, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud aboungnaseng-ovhcloud approved these changes

@anooparveti anooparveti anooparveti approved these changes

@chipp972 chipp972 chipp972 left review comments

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@dectotam dectotam Awaiting requested review from dectotam dectotam is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lionel95200x @chipp972 @anooparveti @aboungnaseng-ovhcloud