Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/key management service #11443

Merged
merged 26 commits into from
Jun 20, 2024
Merged

Feat/key management service #11443

merged 26 commits into from
Jun 20, 2024
+3,609 −479

Conversation

vovh
Copy link
Contributor

@vovh vovh commented Apr 11, 2024 •
edited by darsene
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-13791
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add OVH Key Management Service on the manager (credentials and keys management are not implemented yet)

Related

🎏 Translation

  • CMT-13094

@github-actions github-actions bot added translation required dependencies Pull requests that update a dependency file feature New feature labels Apr 11, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Apr 29, 2024
@vovh vovh force-pushed the feat/key-management-service branch from 1c56612 to 415a228 Compare May 14, 2024 12:38
@github-actions github-actions bot removed has conflicts Has conflicts to resolve before merging labels May 14, 2024
@vovh vovh force-pushed the feat/key-management-service branch 2 times, most recently from cc4333f to a1ffd47 Compare May 14, 2024 15:05
@chipp972 chipp972 force-pushed the feat/key-management-service branch from a1ffd47 to 403c833 Compare May 15, 2024 08:19
@vovh vovh force-pushed the feat/key-management-service branch from eae9871 to 236ad23 Compare May 15, 2024 14:30
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label May 21, 2024
@darsene darsene force-pushed the feat/key-management-service branch from 9a4c108 to d5108ca Compare May 22, 2024 12:58
@github-actions github-actions bot added manager-components enabler and removed dependencies Pull requests that update a dependency file has conflicts Has conflicts to resolve before merging labels May 22, 2024
@darsene darsene force-pushed the feat/key-management-service branch 2 times, most recently from ff4077c to 17cf3b7 Compare May 30, 2024 15:15
@vovh vovh force-pushed the feat/key-management-service branch 2 times, most recently from 918ca13 to f39e566 Compare June 12, 2024 11:58
@vovh vovh force-pushed the feat/key-management-service branch from 6b3c601 to 1be7787 Compare June 19, 2024 15:09
@vovh vovh marked this pull request as ready for review June 19, 2024 15:12
@vovh vovh requested review from a team as code owners June 19, 2024 15:12
darsene and others added 12 commits June 20, 2024 17:17
@darsene @vovh
feat(key-management-service): add kms termination (#11800)
87c408e 
ref: MANAGER-13980

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@darsene @vovh
fix(key-management-service): fix reload app on route path (#11845)
42c22ab 
ref: MANAGER-13567

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@darsene @vovh
feat(key-management-service): add KMS termination on my services (#11844
7ebacd7 
)

ref: MANAGER-13980

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@vovh
feat(key-management-service): add billing section in dashboard
78caefe 
ref: MANAGER-14005

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@vovh
feat(key-management-service): fix actionMenu and contact link
65281a4 
ref: MANAGER-14005
Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@vovh
feat(container): add kms menu entry in sidebar
9074997 
ref: MANAGER-14242
Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@vovh
fix(kms): guide links
4599117 
ref: MANAGER-14451

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
@vovh
fix(kms): fix kms general information
c309753 
ref: MANAGER-14451

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
@vovh
fix(manager-component): clipboard-cell add missing translation
2c75921 
ref: MANAGER-14451

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
@vovh
fix(kms): fix create subtitle ODS text
5ed81aa 
ref: MANAGER-14451

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
@vovh
fix(i18n): add missing translations [CDS 58]
2573582 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@vovh
fix(key-management-service): remove renewal badge for now
55f98d6 
ref: MANAGER-13791

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@vovh vovh force-pushed the feat/key-management-service branch from 1be7787 to 55f98d6 Compare June 20, 2024 16:00
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@vovh vovh changed the base branch from develop to release/components-w26 June 20, 2024 16:11
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jun 20, 2024
@sachinrameshn sachinrameshn merged commit 11e870d into release/components-w26 Jun 20, 2024
6 of 10 checks passed
@sachinrameshn sachinrameshn deleted the feat/key-management-service branch June 20, 2024 16:22
sachinrameshn pushed a commit that referenced this pull request Jun 21, 2024
@vovh @aboungnaseng-ovhcloud
@darsene @ovh-cds @sachinrameshn
Feat/key management service (#11443)
f3a8243 
ref: MANAGER-13791
Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
Co-authored-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com>
Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
Co-authored-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>
Co-authored-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
@sachinrameshn sachinrameshn mentioned this pull request Jun 21, 2024
Open
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@dectotam dectotam dectotam left review comments

@rjamet-ovh rjamet-ovh rjamet-ovh left review comments

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev

Assignees
No one assigned
Labels
container dependencies Pull requests that update a dependency file enabler feature New feature manager-components quality check: ok sign-up translation required universe-bare-metal-cloud universe-hosted-private-cloud universe-hub universe-public-cloud universe-telecom universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vovh @dectotam @darsene @sachinrameshn @rjamet-ovh @lionel95200x @aboungnaseng-ovhcloud