-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hub): delete a warning pop up on manager dashboard #12061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: MANAGER-13856 Signed-off-by: soufien mhelhali <mhalheli.soufien@gmail.com>
mhelhali-soufien
requested review from
oalkabouss,
sachinrameshn and
JacquesLarique
June 18, 2024 06:56
sachinrameshn
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be you need to remove the ovhManagerHubCarousel component itself ? I dont see any usage apart from here.
Quality Gate passedIssues Measures |
qpavy
approved these changes
Jun 20, 2024
sachinrameshn
approved these changes
Jun 20, 2024
mhelhali-soufien
added a commit
that referenced
this pull request
Jun 21, 2024
…)" This reverts commit 76da253.
mhelhali-soufien
added a commit
that referenced
this pull request
Jun 21, 2024
lionel95200x
pushed a commit
that referenced
this pull request
Jun 26, 2024
* feat(hub): delete a warning pop up on manager dashboard ref: MANAGER-13856 Signed-off-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com> * feat(hub): delete carousel and cleanup code --------- Signed-off-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com> Co-authored-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com>
lionel95200x
pushed a commit
that referenced
this pull request
Jun 26, 2024
lionel95200x
added a commit
that referenced
this pull request
Jun 27, 2024
* fix: remove unused translations [CDS] Signed-off-by: CDS <cds@ovh.net> * fix(i18n): add missing translations [CDS 3094] Signed-off-by: CDS Translator Agent <opensource@ovh.net> * feat(pci-private-network): create µapp ref: DTCORE-2033 Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com> Co-Authored-By: Florian Renaut <florian.renaut@corp.ovh.com> Co-Authored-By: Mohammed Hamdoune <mohammed.hamdoune.ext@ovhcloud.com> Co-Authored-By: LIDRISSI Hamid <abdelghani-lidrissi.hamid.ext@ovhcloud.com> * release: cesium-grasshopper Signed-off-by: ovh-cds <opensource@ovh.net> * feat(dedicated.ip): get game protocol from api (#12055) ref: MANAGER-12548 Signed-off-by: Quentin Pavy <quentin.pavy.ext@ovhcloud.com> * fix(config): add missing country code (#12082) ref: MANAGER-14470 Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com> * fix(manager-components): useless test import (#12034) Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com> * feat(dedicated.account): set up kyc fraud feature ref: MANAGER-11940 Signed-off-by: Quentin Pavy <contact@quentinpavy.com> Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> Co-authored-by: benjaminlepine <benjamin.lepine@hotmail.fr> Co-authored-by: Jacques Larique <jacques.larique.ext@ovhcloud.com> * feat(container): pnr v2 (#11723) ref: MANAGER-12939 Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> Co-authored-by: benjaminlepine <benjamin.lepine@hotmail.fr> * release: cesium-grasshopper-1 Signed-off-by: ovh-cds <opensource@ovh.net> * fix(i18n): add missing translations [CDS 3082] Signed-off-by: CDS Translator Agent <opensource@ovh.net> * fix(i18n): add missing translations [CDS 3087] Signed-off-by: CDS Translator Agent <opensource@ovh.net> * fix(i18n): add missing translations [CDS 3038] (#11859) ref: MANAGER-14329 Signed-off-by: CDS Translator Agent <opensource@ovh.net> * feat(rancher): replace with manager-components(#11668) Replace custom components with manager-components ref: MANAGER-14286 Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com> * feat(rancher): update version page for rancher (#11884) ref: TAPC-834 Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com> * fix: remove unused translations [CDS] Signed-off-by: CDS <cds@ovh.net> * fix(i18n): add missing translations [CDS 3094] Signed-off-by: CDS Translator Agent <opensource@ovh.net> * feat(dedicated.ip): get game protocol from api (#12055) ref: MANAGER-12548 Signed-off-by: Quentin Pavy <quentin.pavy.ext@ovhcloud.com> * fix(config): add missing country code (#12082) ref: MANAGER-14470 Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com> * fix(manager-components): useless test import (#12034) Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com> * feat(pci): update project creation documentation links (#11577) ref: TAPC-616 Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com> * feat(pci): add region label for toronto (#11848) ref: TAPC-788 Signed-off-by: Rafik Adiche <rafik.adiche.ext@corp.ovh.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> Co-authored-by: Benjamin Ziehms <benjaminherlin@gmail.com> * fix(overthebox): display graph (#11966) ref: UXCT-598 Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com> * feat(pci-rancher): name input improvement (#11814) ref: TAPC-895 Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * feat(web): add offers banner (#11524) ref: MANAGER-13985 Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * feat(dedicated): limit keyvalue items and add tooltip to inputs (#11615) ref: MANAGER-14074 Signed-off-by: Jean-Baptiste Delon <jean-baptiste.delon@ovhcloud.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * feat(web): update cname error content (#10828) ref: MANAGER-12978 Signed-off-by: sachinrameshn <sachin.ramesh@ovhcloud.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * feat(*): move users management from account to iam (#11391) ref: MANAGER-12811 Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * fix(dedicated): update core config user after account update (#11930) ref: MANAGER-13917 Signed-off-by: Jacques Larique <jacques.larique.ext@ovhcloud.com> * feat(dedicated.dbaas): fix ldp order redirection for us (#11925) (#12011) ref: MANAGER-14405 Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com> * fix(dedicated): replace old windows rescue name by the new one (#11864) ref: MANAGER-14395 Signed-off-by: Kevin Bartier <kevin.bartier.ext@corp.ovh.com> * feat(dedicated.nutanix): us onboarding guide link (#11997) ref: MANAGER-13677 Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com> * feat(dedicated): add button to buy domain in vps dashboard (#11892) ref: MANAGER-14196 Signed-off-by: Valentin Mesny <valentin.mesny.ext@ovhcloud.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * feat(web): remove glue tab if hostsupported is false (#11732) ref: MANAGER-14339 Signed-off-by: Valentin Mesny <valentin.mesny.ext@ovhcloud.com> * fix(dedicated): disable view service details for byoip (#12001) ref: MANAGER-14459 Signed-off-by: sachinrameshn <sachin.ramesh@ovhcloud.com> * fix(i18n): add missing translations [CDS 3051] (#11913) ref: MANAGER-14417 Signed-off-by: CDS Translator Agent <opensource@ovh.net> * fix(container): hide preloader when mfa enrollment is displayed (#11924) ref: MANAGER-14444 Signed-off-by: Jacques Larique <jacques.larique.ext@ovhcloud.com> * fix(dedicated): untranslated keys in ticket creation (#11904) ref: MANAGER-14152 Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * fix(*): fix log to customer superseded css for oui-datagrid (#12057) ref: MANAGER-14510, PRB0041254 Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com> * feat(pci-rancher): onboarding page redirect user to guides (#11736) ref: TAPC-832 Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com> Co-authored-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com> * feat(container): add payment method warning popup (#10732) ref: MANAGER-12494 Signed-off-by: Bruno MARQUES <bruno.marques.ext@corp.ovh.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com> Co-authored-by: benjaminlepine <benjamin.lepine@hotmail.fr> Co-authored-by: oalkabouss <omaralkabous@gmail.com> Co-authored-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com> * fix(coldarchive): breaking change of API for coldarchive (#11646) ref: TAPC-1103 Signed-off-by: Ludovic Lamarche <snigle64@gmail.com> * fix(telecom): french mistakes (#11994) ref: MANAGER-14479 Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * feat(pci): add lz under right continent (#11746) (#12010) ref: MANAGER-14369 Signed-off-by: sachinrameshn <sachin.ramesh@ovhcloud.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * feat(dedicated): update insurance msg after uploaded In id doc (#11502) ref: MANAGER-14186 Signed-off-by: oalkabouss <omaralkabous@gmail.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * feat(pci): free local zones banner (#12084) ref: TAPC-1117 Signed-off-by: Yann Lojewski <yann.lojewski.ext@ovhcloud.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * Feat/key management service (#11443) ref: MANAGER-13791 Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com> Co-authored-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com> Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com> Co-authored-by: Romain Jamet <romain.jamet.ext@corp.ovh.com> Co-authored-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com> Co-authored-by: Romain Jamet <romain.jamet.ext@corp.ovh.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> * ci: add manager-components issue templates (#12097) New issue templates for feature/bug requests on manager components ref: MANAGER-14530 Signed-off-by: Anoop N <anoop.n@ovhcloud.com> * ci: fix manager-components issue templates (#12098) ref: MANAGER-14530 Signed-off-by: Anoop N <anoop.n@ovhcloud.com> * feat(hub): delete a warning pop up on manager dashboard (#12061) * feat(hub): delete a warning pop up on manager dashboard ref: MANAGER-13856 Signed-off-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com> * feat(hub): delete carousel and cleanup code --------- Signed-off-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com> Co-authored-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com> * release: cesium-grasshopper-2 Signed-off-by: ovh-cds <opensource@ovh.net> * Revert "feat(hub): delete a warning pop up on manager dashboard (#12061)" (#12100) This reverts commit 76da253. Signed-off-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com> * release: cesium-grasshopper-3 Signed-off-by: ovh-cds <opensource@ovh.net> * ci: update CONTRIBUTORS and CODEOWNERS (#12106) ref: MANAGER-14530 Signed-off-by: Anoop N <anoop.n@ovhcloud.com> * fix(i18n): add missing translations [CDS 3108] (#12113) ref: TAPC-832 Signed-off-by: CDS Translator Agent <opensource@ovh.net> * fix(*): fix onboarding layout in manager component and kms (#12112) ref: TAPC-832 Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com> * fix(dedicated): fixed lint error on kyc fraud (#12096) ref: MANAGER-11940 Signed-off-by: Jacques Larique <jacques.larique.ext@ovhcloud.com> * fix: remove unused translations [CDS] Signed-off-by: CDS <cds@ovh.net> * release: cesium-grasshopper-4 Signed-off-by: ovh-cds <opensource@ovh.net> * fix(container): fix issue with kms menu entry in pci menu (#12137) ref: MANAGER-13791 Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com> * fix(i18n): add missing translations [CDS 3111] Signed-off-by: CDS Translator Agent <opensource@ovh.net> * perf(dedicated.server): fetch server list without details (#12088) ref: MANAGER-14260 Signed-off-by: Quentin Pavy <quentin.pavy.ext@ovhcloud.com> * release: samarium-lizard Signed-off-by: ovh-cds <opensource@ovh.net> * feat(pci.savings-plan): create savings plan micro-app ref: TAPC-1084 Signed-off-by: Rafik Adiche <rafik.adiche.ext@corp.ovh.com> --------- Signed-off-by: CDS <cds@ovh.net> Signed-off-by: CDS Translator Agent <opensource@ovh.net> Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com> Signed-off-by: ovh-cds <opensource@ovh.net> Signed-off-by: Quentin Pavy <quentin.pavy.ext@ovhcloud.com> Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com> Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com> Signed-off-by: Quentin Pavy <contact@quentinpavy.com> Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com> Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com> Signed-off-by: Rafik Adiche <rafik.adiche.ext@corp.ovh.com> Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com> Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com> Signed-off-by: Jean-Baptiste Delon <jean-baptiste.delon@ovhcloud.com> Signed-off-by: sachinrameshn <sachin.ramesh@ovhcloud.com> Signed-off-by: Jacques Larique <jacques.larique.ext@ovhcloud.com> Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com> Signed-off-by: Kevin Bartier <kevin.bartier.ext@corp.ovh.com> Signed-off-by: Valentin Mesny <valentin.mesny.ext@ovhcloud.com> Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com> Signed-off-by: Bruno MARQUES <bruno.marques.ext@corp.ovh.com> Signed-off-by: Ludovic Lamarche <snigle64@gmail.com> Signed-off-by: oalkabouss <omaralkabous@gmail.com> Signed-off-by: Yann Lojewski <yann.lojewski.ext@ovhcloud.com> Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com> Signed-off-by: Anoop N <anoop.n@ovhcloud.com> Signed-off-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com> Co-authored-by: CDS <lionel95200x@users.noreply.github.com> Co-authored-by: Yoann Fievez <yoann.fievez@ovhcloud.com> Co-authored-by: Florian Renaut <florian.renaut@corp.ovh.com> Co-authored-by: Mohammed Hamdoune <mohammed.hamdoune.ext@ovhcloud.com> Co-authored-by: LIDRISSI Hamid <abdelghani-lidrissi.hamid.ext@ovhcloud.com> Co-authored-by: qpavy <contact@quentinpavy.com> Co-authored-by: rjamet-ovh <157609363+rjamet-ovh@users.noreply.github.com> Co-authored-by: JacquesLarique <134954692+JacquesLarique@users.noreply.github.com> Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com> Co-authored-by: CDS Translator Agent <opensource@ovh.net> Co-authored-by: benjaminlepine <benjamin.lepine@hotmail.fr> Co-authored-by: Jacques Larique <jacques.larique.ext@ovhcloud.com> Co-authored-by: Maxime Bajeux <max.bajeux@gmail.com> Co-authored-by: CDS Translator Agent <ovh-ux-cds@users.noreply.github.com> Co-authored-by: pdepaepe <pdepaepe@users.noreply.github.com> Co-authored-by: selm3n <30338862+selm3n@users.noreply.github.com> Co-authored-by: Benjamin Ziehms <benjaminherlin@gmail.com> Co-authored-by: Stéphanie MOALLIC <stephanie.moallic@gmail.com> Co-authored-by: antonymarion <marionantony@gmail.com> Co-authored-by: JayBeeDe <jb.social@outlook.com> Co-authored-by: Sachin Ramesh <104337442+sachinrameshn@users.noreply.github.com> Co-authored-by: Anoop N <anoop.n@ovhcloud.com> Co-authored-by: Kevin Bartier <k.kedu596@gmail.com> Co-authored-by: Amandine Dt <dectot.amandine@gmail.com> Co-authored-by: vmesnyovh <150937224+vmesnyovh@users.noreply.github.com> Co-authored-by: darsene <72250222+darsene@users.noreply.github.com> Co-authored-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com> Co-authored-by: Bruno MARQUES <139278215+BrunoMarquesOVH@users.noreply.github.com> Co-authored-by: oalkabouss <omaralkabous@gmail.com> Co-authored-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com> Co-authored-by: Ludovic Lamarche <snigle64@gmail.com> Co-authored-by: Yann Lojewski <yann.lojewski@gmail.com> Co-authored-by: vovh <155978769+vovh@users.noreply.github.com> Co-authored-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com> Co-authored-by: Romain Jamet <romain.jamet.ext@corp.ovh.com> Co-authored-by: mhelhali-soufien <159853039+mhelhali-soufien@users.noreply.github.com> Co-authored-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com> Co-authored-by: Rafik Adiche <rafik.adiche.ext@corp.ovh.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master
Only FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
Related