Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): fix onboarding layout in manager component and kms #12112

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix(*): fix onboarding layout in manager component and kms #12112

merged 1 commit into from
Jun 24, 2024

Conversation

vovh
Copy link
Contributor

@vovh vovh commented Jun 24, 2024 •
edited
Loading

Question Answer
Branch? release/components-w26
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #TAPC-832
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@github-actions github-actions bot added manager-components enabler bug Something isn't working labels Jun 24, 2024
@vovh
fix(*): fix onboarding layout in manager component and kms
8359b83 
REF: TAPC-832

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@vovh vovh force-pushed the fix/onboarding-layout-issue branch from 5c9ff8a to 8359b83 Compare June 24, 2024 10:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vovh vovh marked this pull request as ready for review June 24, 2024 12:05
@vovh vovh requested a review from a team as a code owner June 24, 2024 12:05
@vovh vovh requested review from sidlynx and seven-amid and removed request for a team June 24, 2024 12:05
lionel95200x
lionel95200x reviewed Jun 24, 2024
View reviewed changes
packages/manager/apps/key-management-service/src/pages/onboarding/index.tsx

return (
<OnboardingLayout
title={t('title')}
img={{ src: onboardingImgSrc }}
description={t('description')}
additionalDescriptions={[t('description_secondary')]}
description={descriptionsKeys.map((descKey) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little strange to pass some OdsText under OdsText
But not the target to this PR so i think we should rethink this topic later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.
Noted for my ongoing refacto.

@sachinrameshn sachinrameshn merged commit 3415206 into release/components-w26 Jun 24, 2024
13 of 14 checks passed
@sachinrameshn sachinrameshn deleted the fix/onboarding-layout-issue branch June 24, 2024 16:33
lionel95200x pushed a commit that referenced this pull request Jun 26, 2024
@vovh
fix(*): fix onboarding layout in manager component and kms (#12112)
7076d77 
ref: TAPC-832
Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
lionel95200x added a commit that referenced this pull request Jun 27, 2024
@brofik @lionel95200x
@kqesar @frenautvh @qpavy @rjamet-ovh @JacquesLarique @darsene @ovh-cds @benjaminlepine @MaximeBajeux @ovh-ux-cds @pdepaepe @selm3n @reenjii @Steffy29 @antonymarion @JayBeeDe @sachinrameshn @anooparveti @Dampen59 @dectotam @vmesnyovh @BrunoMarquesOVH @oalkabouss @snigle @y4nnL @vovh @aboungnaseng-ovhcloud @mhelhali-soufien
feat(pci.savings-plan): add savings plan micro-app (#11936)
7c873fd 
* fix: remove unused translations [CDS]

Signed-off-by: CDS <cds@ovh.net>

* fix(i18n): add missing translations [CDS 3094]

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

* feat(pci-private-network): create µapp

ref: DTCORE-2033

Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com>
Co-Authored-By: Florian Renaut <florian.renaut@corp.ovh.com>
Co-Authored-By: Mohammed Hamdoune <mohammed.hamdoune.ext@ovhcloud.com>
Co-Authored-By: LIDRISSI Hamid <abdelghani-lidrissi.hamid.ext@ovhcloud.com>

* release: cesium-grasshopper

Signed-off-by: ovh-cds <opensource@ovh.net>

* feat(dedicated.ip): get game protocol from api (#12055)

ref: MANAGER-12548

Signed-off-by: Quentin Pavy <quentin.pavy.ext@ovhcloud.com>

* fix(config): add missing country code (#12082)

ref: MANAGER-14470

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>

* fix(manager-components): useless test import (#12034)

Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>

* feat(dedicated.account): set up kyc fraud feature

ref: MANAGER-11940

Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Co-authored-by: benjaminlepine <benjamin.lepine@hotmail.fr>
Co-authored-by: Jacques Larique <jacques.larique.ext@ovhcloud.com>

* feat(container): pnr v2 (#11723)

ref: MANAGER-12939

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Co-authored-by: benjaminlepine <benjamin.lepine@hotmail.fr>

* release: cesium-grasshopper-1

Signed-off-by: ovh-cds <opensource@ovh.net>

* fix(i18n): add missing translations [CDS 3082]

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

* fix(i18n): add missing translations [CDS 3087]

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

* fix(i18n): add missing translations [CDS 3038] (#11859)

ref: MANAGER-14329

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

* feat(rancher): replace with manager-components(#11668)

Replace custom components with manager-components
ref: MANAGER-14286

Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>

* feat(rancher): update version page for rancher (#11884)

ref: TAPC-834

Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>

* fix: remove unused translations [CDS]

Signed-off-by: CDS <cds@ovh.net>

* fix(i18n): add missing translations [CDS 3094]

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

* feat(dedicated.ip): get game protocol from api (#12055)

ref: MANAGER-12548

Signed-off-by: Quentin Pavy <quentin.pavy.ext@ovhcloud.com>

* fix(config): add missing country code (#12082)

ref: MANAGER-14470

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>

* fix(manager-components): useless test import (#12034)

Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>

* feat(pci): update project creation documentation links (#11577)

ref: TAPC-616
Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com>

* feat(pci): add region label for toronto (#11848)

ref: TAPC-788
Signed-off-by: Rafik Adiche <rafik.adiche.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Co-authored-by: Benjamin Ziehms <benjaminherlin@gmail.com>

* fix(overthebox): display graph (#11966)

ref: UXCT-598
Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>

* feat(pci-rancher): name input improvement (#11814)

ref: TAPC-895
Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* feat(web): add offers banner (#11524)

ref: MANAGER-13985
Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* feat(dedicated): limit keyvalue items and add tooltip to inputs (#11615)

ref: MANAGER-14074
Signed-off-by: Jean-Baptiste Delon <jean-baptiste.delon@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* feat(web): update cname error content (#10828)

ref: MANAGER-12978
Signed-off-by: sachinrameshn <sachin.ramesh@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* feat(*): move users management from account to iam (#11391)

ref: MANAGER-12811
Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* fix(dedicated): update core config user after account update (#11930)

ref: MANAGER-13917
Signed-off-by: Jacques Larique <jacques.larique.ext@ovhcloud.com>

* feat(dedicated.dbaas): fix ldp order redirection for us (#11925) (#12011)

ref: MANAGER-14405
Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com>

* fix(dedicated): replace old windows rescue name by the new one (#11864)

ref: MANAGER-14395
Signed-off-by: Kevin Bartier <kevin.bartier.ext@corp.ovh.com>

* feat(dedicated.nutanix): us onboarding guide link (#11997)

ref: MANAGER-13677
Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com>

* feat(dedicated): add button to buy domain in vps dashboard (#11892)

ref: MANAGER-14196
Signed-off-by: Valentin Mesny <valentin.mesny.ext@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* feat(web): remove glue tab if hostsupported is false (#11732)

ref: MANAGER-14339
Signed-off-by: Valentin Mesny <valentin.mesny.ext@ovhcloud.com>

* fix(dedicated): disable view service details for byoip (#12001)

ref: MANAGER-14459
Signed-off-by: sachinrameshn <sachin.ramesh@ovhcloud.com>

* fix(i18n): add missing translations [CDS 3051] (#11913)

ref: MANAGER-14417
Signed-off-by: CDS Translator Agent <opensource@ovh.net>

* fix(container): hide preloader when mfa enrollment is displayed (#11924)

ref: MANAGER-14444
Signed-off-by: Jacques Larique <jacques.larique.ext@ovhcloud.com>

* fix(dedicated): untranslated keys in ticket creation (#11904)

ref: MANAGER-14152
Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* fix(*): fix log to customer superseded css for oui-datagrid (#12057)

ref: MANAGER-14510, PRB0041254
Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>

* feat(pci-rancher): onboarding page redirect user to guides (#11736)

ref: TAPC-832
Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com>
Co-authored-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>

* feat(container): add payment method warning popup (#10732)

ref: MANAGER-12494
Signed-off-by: Bruno MARQUES <bruno.marques.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: benjaminlepine <benjamin.lepine@hotmail.fr>
Co-authored-by: oalkabouss <omaralkabous@gmail.com>
Co-authored-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>

* fix(coldarchive): breaking change of API for coldarchive (#11646)

ref: TAPC-1103
Signed-off-by: Ludovic Lamarche <snigle64@gmail.com>

* fix(telecom): french mistakes (#11994)

ref: MANAGER-14479
Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* feat(pci): add lz under right continent (#11746) (#12010)

ref: MANAGER-14369
Signed-off-by: sachinrameshn <sachin.ramesh@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* feat(dedicated): update insurance msg after uploaded In id doc (#11502)

ref: MANAGER-14186
Signed-off-by: oalkabouss <omaralkabous@gmail.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* feat(pci): free local zones banner (#12084)

ref: TAPC-1117
Signed-off-by: Yann Lojewski <yann.lojewski.ext@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* Feat/key management service (#11443)

ref: MANAGER-13791
Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
Co-authored-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com>
Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
Co-authored-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>
Co-authored-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>

* ci: add manager-components issue templates (#12097)

New issue templates for feature/bug requests on manager components
 ref: MANAGER-14530

Signed-off-by: Anoop N <anoop.n@ovhcloud.com>

* ci: fix manager-components issue templates (#12098)

ref: MANAGER-14530

Signed-off-by: Anoop N <anoop.n@ovhcloud.com>

* feat(hub): delete a warning pop up on manager dashboard (#12061)

* feat(hub): delete a warning pop up on manager dashboard

ref: MANAGER-13856

Signed-off-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com>

* feat(hub): delete carousel and cleanup code

---------

Signed-off-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com>
Co-authored-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com>

* release: cesium-grasshopper-2

Signed-off-by: ovh-cds <opensource@ovh.net>

* Revert "feat(hub): delete a warning pop up on manager dashboard (#12061)" (#12100)

This reverts commit 76da253.
Signed-off-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com>

* release: cesium-grasshopper-3

Signed-off-by: ovh-cds <opensource@ovh.net>

* ci: update CONTRIBUTORS and CODEOWNERS (#12106)

ref: MANAGER-14530

Signed-off-by: Anoop N <anoop.n@ovhcloud.com>

* fix(i18n): add missing translations [CDS 3108] (#12113)

ref: TAPC-832 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>

* fix(*): fix onboarding layout in manager component and kms (#12112)

ref: TAPC-832
Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>

* fix(dedicated): fixed lint error on kyc fraud (#12096)

ref: MANAGER-11940
Signed-off-by: Jacques Larique <jacques.larique.ext@ovhcloud.com>

* fix: remove unused translations [CDS]

Signed-off-by: CDS <cds@ovh.net>

* release: cesium-grasshopper-4

Signed-off-by: ovh-cds <opensource@ovh.net>

* fix(container): fix issue with kms menu entry in pci menu (#12137)

ref: MANAGER-13791

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>

* fix(i18n): add missing translations [CDS 3111]

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

* perf(dedicated.server): fetch server list without details (#12088)

ref: MANAGER-14260

Signed-off-by: Quentin Pavy <quentin.pavy.ext@ovhcloud.com>

* release: samarium-lizard

Signed-off-by: ovh-cds <opensource@ovh.net>

* feat(pci.savings-plan): create savings plan micro-app

ref: TAPC-1084
Signed-off-by: Rafik Adiche <rafik.adiche.ext@corp.ovh.com>

---------

Signed-off-by: CDS <cds@ovh.net>
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
Signed-off-by: Yoann Fievez <yoann.fievez@ovhcloud.com>
Signed-off-by: ovh-cds <opensource@ovh.net>
Signed-off-by: Quentin Pavy <quentin.pavy.ext@ovhcloud.com>
Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>
Signed-off-by: Quentin Pavy <contact@quentinpavy.com>
Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com>
Signed-off-by: Rafik Adiche <rafik.adiche.ext@corp.ovh.com>
Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
Signed-off-by: Jean-Baptiste Delon <jean-baptiste.delon@ovhcloud.com>
Signed-off-by: sachinrameshn <sachin.ramesh@ovhcloud.com>
Signed-off-by: Jacques Larique <jacques.larique.ext@ovhcloud.com>
Signed-off-by: Amandine Dectot <amandine.dectot.ext@corp.ovh.com>
Signed-off-by: Kevin Bartier <kevin.bartier.ext@corp.ovh.com>
Signed-off-by: Valentin Mesny <valentin.mesny.ext@ovhcloud.com>
Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Signed-off-by: Bruno MARQUES <bruno.marques.ext@corp.ovh.com>
Signed-off-by: Ludovic Lamarche <snigle64@gmail.com>
Signed-off-by: oalkabouss <omaralkabous@gmail.com>
Signed-off-by: Yann Lojewski <yann.lojewski.ext@ovhcloud.com>
Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
Signed-off-by: Anoop N <anoop.n@ovhcloud.com>
Signed-off-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com>
Co-authored-by: CDS <lionel95200x@users.noreply.github.com>
Co-authored-by: Yoann Fievez <yoann.fievez@ovhcloud.com>
Co-authored-by: Florian Renaut <florian.renaut@corp.ovh.com>
Co-authored-by: Mohammed Hamdoune <mohammed.hamdoune.ext@ovhcloud.com>
Co-authored-by: LIDRISSI Hamid <abdelghani-lidrissi.hamid.ext@ovhcloud.com>
Co-authored-by: qpavy <contact@quentinpavy.com>
Co-authored-by: rjamet-ovh <157609363+rjamet-ovh@users.noreply.github.com>
Co-authored-by: JacquesLarique <134954692+JacquesLarique@users.noreply.github.com>
Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Co-authored-by: benjaminlepine <benjamin.lepine@hotmail.fr>
Co-authored-by: Jacques Larique <jacques.larique.ext@ovhcloud.com>
Co-authored-by: Maxime Bajeux <max.bajeux@gmail.com>
Co-authored-by: CDS Translator Agent <ovh-ux-cds@users.noreply.github.com>
Co-authored-by: pdepaepe <pdepaepe@users.noreply.github.com>
Co-authored-by: selm3n <30338862+selm3n@users.noreply.github.com>
Co-authored-by: Benjamin Ziehms <benjaminherlin@gmail.com>
Co-authored-by: Stéphanie MOALLIC <stephanie.moallic@gmail.com>
Co-authored-by: antonymarion <marionantony@gmail.com>
Co-authored-by: JayBeeDe <jb.social@outlook.com>
Co-authored-by: Sachin Ramesh <104337442+sachinrameshn@users.noreply.github.com>
Co-authored-by: Anoop N <anoop.n@ovhcloud.com>
Co-authored-by: Kevin Bartier <k.kedu596@gmail.com>
Co-authored-by: Amandine Dt <dectot.amandine@gmail.com>
Co-authored-by: vmesnyovh <150937224+vmesnyovh@users.noreply.github.com>
Co-authored-by: darsene <72250222+darsene@users.noreply.github.com>
Co-authored-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>
Co-authored-by: Bruno MARQUES <139278215+BrunoMarquesOVH@users.noreply.github.com>
Co-authored-by: oalkabouss <omaralkabous@gmail.com>
Co-authored-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
Co-authored-by: Ludovic Lamarche <snigle64@gmail.com>
Co-authored-by: Yann Lojewski <yann.lojewski@gmail.com>
Co-authored-by: vovh <155978769+vovh@users.noreply.github.com>
Co-authored-by: Alex Boungnaseng <alex.boungnaseng.ext@corp.ovh.com>
Co-authored-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
Co-authored-by: mhelhali-soufien <159853039+mhelhali-soufien@users.noreply.github.com>
Co-authored-by: soufien mhelhali <soufien.mhelhali.ext@ovhcloud.com>
Co-authored-by: Rafik Adiche <rafik.adiche.ext@corp.ovh.com>
@brofik brofik mentioned this pull request Jun 27, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel95200x lionel95200x lionel95200x left review comments

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@darsene darsene darsene approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
bug Something isn't working enabler manager-components quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vovh @lionel95200x @darsene @JacquesLarique @sachinrameshn