Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dedicated): add missing state parameter #11694

Conversation

Steffy29
Copy link
Contributor

@Steffy29 Steffy29 commented May 13, 2024

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MANAGER-14317
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

add missing state parameter

Related

@Steffy29 Steffy29 self-assigned this May 13, 2024
@Steffy29 Steffy29 requested a review from a team as a code owner May 13, 2024 13:17
@Steffy29 Steffy29 added the bug Something isn't working label May 13, 2024
@Steffy29 Steffy29 force-pushed the MANAGER-14317-network-security-traffic-chart-fix-error-message branch from 0779611 to 310d8c8 Compare May 13, 2024 15:18
@Steffy29 Steffy29 requested a review from darsene May 13, 2024 15:19
@darsene
Copy link
Contributor

darsene commented May 14, 2024

@Steffy29 , seems the fix in already taken in account on our side -> #11676

@Steffy29
Copy link
Contributor Author

Sorry @darsene but your version(#11676) doesn't work.

@Steffy29 Steffy29 force-pushed the MANAGER-14317-network-security-traffic-chart-fix-error-message branch from 310d8c8 to 6bd6280 Compare May 14, 2024 09:10
ref: MANAGER-14317

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
@Steffy29 Steffy29 force-pushed the MANAGER-14317-network-security-traffic-chart-fix-error-message branch from 6bd6280 to 254dbd4 Compare May 14, 2024 09:18
@Steffy29 Steffy29 requested a review from darsene May 14, 2024 09:19
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@darsene darsene changed the base branch from master to release/components-w21 May 17, 2024 07:35
@darsene darsene merged commit 1c02ad6 into release/components-w21 May 17, 2024
14 of 15 checks passed
@darsene darsene deleted the MANAGER-14317-network-security-traffic-chart-fix-error-message branch May 17, 2024 08:36
@darsene darsene mentioned this pull request May 17, 2024
18 tasks
darsene pushed a commit that referenced this pull request May 17, 2024
ref: MANAGER-14317

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
sidlynx pushed a commit that referenced this pull request May 21, 2024
ref: MANAGER-14317

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
sidlynx pushed a commit that referenced this pull request May 21, 2024
ref: MANAGER-14317

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working universe-bare-metal-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants