Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(key-management-service): add KMS termination on my services #11844

Merged
merged 1 commit into from
Jun 4, 2024
Merged

feat(key-management-service): add KMS termination on my services #11844

merged 1 commit into from
Jun 4, 2024

Conversation

darsene
Copy link
Contributor

@darsene darsene commented May 30, 2024

ref: MANAGER-13980

Question Answer
Branch? feat/key-management-service
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-13980
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@darsene darsene requested a review from a team as a code owner May 30, 2024 15:03
@darsene darsene requested review from dectotam, anooparveti and ghyenne and removed request for a team May 30, 2024 15:03
@darsene darsene force-pushed the feat/key-management-service branch from ff4077c to 17cf3b7 Compare May 30, 2024 15:15
@darsene darsene requested review from a team as code owners May 30, 2024 15:15
@darsene darsene requested review from kqesar and seven-amid and removed request for a team May 30, 2024 15:15
@darsene darsene force-pushed the feat/MANAGER-13980-my-services branch from 8e80025 to 0f38c7d Compare May 30, 2024 15:24
@darsene darsene force-pushed the feat/MANAGER-13980-my-services branch from 0f38c7d to d915d1a Compare June 3, 2024 16:23
@darsene
feat(key-management-service): add KMS termination on my services
6159443 
ref: MANAGER-13980

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@darsene darsene force-pushed the feat/MANAGER-13980-my-services branch from d915d1a to 6159443 Compare June 4, 2024 07:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@darsene darsene merged commit 0b09aa8 into feat/key-management-service Jun 4, 2024
12 of 13 checks passed
@darsene darsene deleted the feat/MANAGER-13980-my-services branch June 4, 2024 14:20
vovh pushed a commit that referenced this pull request Jun 12, 2024
@darsene @vovh
feat(key-management-service): add KMS termination on my services (#11844
5fc125c 
)

ref: MANAGER-13980

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
qpavy pushed a commit that referenced this pull request Jun 17, 2024
@darsene
feat(key-management-service): add KMS termination on my service (#11844)
45bddab 
ref: MANAGER-13980

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
vovh pushed a commit that referenced this pull request Jun 19, 2024
@darsene @vovh
feat(key-management-service): add KMS termination on my services (#11844
f987292 
)

ref: MANAGER-13980

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
vovh pushed a commit that referenced this pull request Jun 20, 2024
@darsene @vovh
feat(key-management-service): add KMS termination on my services (#11844
7ebacd7 
)

ref: MANAGER-13980

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qpavy qpavy qpavy approved these changes

@ghyenne ghyenne ghyenne approved these changes

@dectotam dectotam Awaiting requested review from dectotam dectotam is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darsene @qpavy @ghyenne