Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(key-management-service): fix reload app on route path #11845

Merged
merged 1 commit into from
May 31, 2024
Merged

fix(key-management-service): fix reload app on route path #11845

merged 1 commit into from
May 31, 2024

Conversation

darsene
Copy link
Contributor

@darsene darsene commented May 30, 2024

ref: MANAGER-13567

Question Answer
Branch? feat/key-management-service
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MANAGER-13567
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@darsene
fix(key-management-service): fix reload app on route path
ea4236f 
ref: MANAGER-13567

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@darsene darsene requested review from a team as code owners May 30, 2024 15:42
@darsene darsene requested review from kqesar and seven-amid and removed request for a team May 30, 2024 15:42
@github-actions github-actions bot added enabler bug Something isn't working labels May 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@darsene darsene merged commit 9f1a321 into feat/key-management-service May 31, 2024
14 checks passed
@darsene darsene deleted the fix/MANAGER-13567 branch May 31, 2024 15:57
vovh pushed a commit that referenced this pull request Jun 12, 2024
@darsene @vovh
fix(key-management-service): fix reload app on route path (#11845)
54eb038 
ref: MANAGER-13567

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
vovh pushed a commit that referenced this pull request Jun 19, 2024
@darsene @vovh
fix(key-management-service): fix reload app on route path (#11845)
746dc2f 
ref: MANAGER-13567

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
vovh pushed a commit that referenced this pull request Jun 20, 2024
@darsene @vovh
fix(key-management-service): fix reload app on route path (#11845)
42c22ab 
ref: MANAGER-13567

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@vovh vovh vovh approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
bug Something isn't working enabler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darsene @JacquesLarique @vovh