Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-object-storage): bucket versioning v1 #11981

Merged
merged 4 commits into from
Jul 15, 2024
Merged

feat(pci-object-storage): bucket versioning v1 #11981

merged 4 commits into from
Jul 15, 2024

Conversation

selm3n
Copy link
Contributor

@selm3n selm3n commented Jun 12, 2024

ref: TAPC-157

Question Answer
Branch? / develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #...TAPC-157
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@selm3n selm3n requested a review from a team as a code owner June 12, 2024 14:36
@selm3n selm3n force-pushed the feat/TAPC-157 branch 3 times, most recently from 590a988 to 0a96fb7 Compare June 12, 2024 15:23
reenjii
reenjii previously approved these changes Jun 12, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jun 17, 2024
JacquesLarique
JacquesLarique previously approved these changes Jun 17, 2024
View reviewed changes
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jun 17, 2024
JacquesLarique
JacquesLarique previously approved these changes Jun 17, 2024
View reviewed changes
reenjii
reenjii previously approved these changes Jun 17, 2024
View reviewed changes
brofik
brofik previously approved these changes Jun 18, 2024
View reviewed changes
@ovh-cds
fix(i18n): add missing translations [CDS 3148]
dca9ff6 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
JacquesLarique
JacquesLarique previously approved these changes Jul 10, 2024
View reviewed changes
y4nnL
y4nnL previously approved these changes Jul 10, 2024
View reviewed changes
@y4nnL y4nnL self-requested a review July 10, 2024 13:46
feat(pci-object-storage): bucket versioning v1
f256895 
ref: TAPC-157
Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com>
@selm3n selm3n dismissed stale reviews from y4nnL and JacquesLarique via f256895 July 11, 2024 10:02
JacquesLarique
JacquesLarique previously approved these changes Jul 11, 2024
View reviewed changes
darsene
darsene previously approved these changes Jul 11, 2024
View reviewed changes
@antonymarion antonymarion changed the base branch from develop to release/components-w29 July 11, 2024 15:20
@antonymarion antonymarion dismissed stale reviews from darsene and JacquesLarique July 11, 2024 15:20

The base branch was changed.

ghyenne
ghyenne previously approved these changes Jul 11, 2024
View reviewed changes
feat(pci-object-storage): bucket versioning v1
16cf43b 
ref: TAPC-157
Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com>
@selm3n selm3n dismissed stale reviews from ghyenne and mhelhali-soufien via 16cf43b July 12, 2024 07:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@antonymarion antonymarion merged commit 05363f6 into release/components-w29 Jul 15, 2024
13 of 14 checks passed
@antonymarion antonymarion deleted the feat/TAPC-157 branch July 15, 2024 09:23
@antonymarion antonymarion mentioned this pull request Jul 15, 2024
Merged
15 tasks
antonymarion pushed a commit that referenced this pull request Jul 15, 2024
@selm3n
feat(pci-object-storage): bucket versioning v1 (#11981)
8064730 
ref: TAPC-157

Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com>
antonymarion pushed a commit that referenced this pull request Jul 15, 2024
@selm3n @antonymarion
feat(pci-object-storage): bucket versioning v1 (#11981)
7eaa856 
ref: TAPC-157

Signed-off-by: Selmen AKRMI <selmen.akrmi.ext@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@darsene darsene darsene approved these changes

@mhelhali-soufien mhelhali-soufien mhelhali-soufien left review comments

@ghyenne ghyenne ghyenne left review comments

@brofik brofik brofik left review comments

@reenjii reenjii reenjii left review comments

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@y4nnL y4nnL Awaiting requested review from y4nnL

Assignees
No one assigned
Labels
feature New feature quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@selm3n @reenjii @y4nnL @brofik @ghyenne @darsene @JacquesLarique @mhelhali-soufien @antonymarion