Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(overthebox): rework on detail view and change offer #12144

Merged
merged 1 commit into from
Jul 11, 2024
Merged

feat(overthebox): rework on detail view and change offer #12144

merged 1 commit into from
Jul 11, 2024

Conversation

Steffy29
Copy link
Contributor

@Steffy29 Steffy29 commented Jun 26, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #UXCT-600
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Rework on detail view
Add unlink button
Change offer

Related

@Steffy29 Steffy29 self-assigned this Jun 26, 2024
antonymarion
antonymarion previously approved these changes Jul 2, 2024
View reviewed changes
@Steffy29 Steffy29 force-pushed the UXCT-600-overthebox-rework-homepage branch from 88e97b4 to 09ace82 Compare July 2, 2024 12:55
@Steffy29 Steffy29 requested a review from a team as a code owner July 2, 2024 12:55
@Steffy29 Steffy29 force-pushed the UXCT-600-overthebox-rework-homepage branch from 09ace82 to c5b5040 Compare July 3, 2024 08:47
@Steffy29 Steffy29 requested a review from ghyenne July 3, 2024 12:35
ghyenne
ghyenne previously approved these changes Jul 4, 2024
View reviewed changes
@Steffy29 Steffy29 force-pushed the UXCT-600-overthebox-rework-homepage branch from c5b5040 to a1a0609 Compare July 4, 2024 12:36
@Steffy29 Steffy29 requested a review from anooparveti July 4, 2024 12:37
@Steffy29 Steffy29 changed the title feat(overthebox): rework on detail view feat(overthebox): rework on detail view and change offer Jul 10, 2024
antonymarion
antonymarion previously approved these changes Jul 11, 2024
View reviewed changes
ghyenne
ghyenne previously approved these changes Jul 11, 2024
View reviewed changes
@antonymarion antonymarion changed the base branch from develop to release/components-w29 July 11, 2024 11:19
@antonymarion antonymarion dismissed stale reviews from ghyenne and themself July 11, 2024 11:19

The base branch was changed.

qpavy
qpavy previously approved these changes Jul 11, 2024
View reviewed changes
@antonymarion antonymarion deleted the branch release/components-w29 July 11, 2024 12:19
@Steffy29 Steffy29 reopened this Jul 11, 2024
anooparveti
anooparveti previously approved these changes Jul 11, 2024
View reviewed changes
feat(overthebox): rework on detail view
1fd494a 
ref: UXCT-600
ref: UXCT-268
ref: UXCT-604
ref: UXCT-605

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>

fix(i18n): add missing translations [CDS 3153]

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

feat(overthebox): add change offer component - offer list

ref: UXCT-604

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>

feat(overthebox): change offer - select contact

ref: UXCT-605

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>

feat(overthebox): change offer - summary

ref: UXCT-593

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>

fix(i18n): add missing translations [CDS 67]

Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@Steffy29 Steffy29 dismissed stale reviews from anooparveti and qpavy via 1fd494a July 11, 2024 14:09
@Steffy29 Steffy29 force-pushed the UXCT-600-overthebox-rework-homepage branch from b459f38 to 1fd494a Compare July 11, 2024 14:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@antonymarion antonymarion mentioned this pull request Jul 11, 2024
Merged
15 tasks
@antonymarion antonymarion merged commit e90a225 into release/components-w29 Jul 11, 2024
14 checks passed
@antonymarion antonymarion deleted the UXCT-600-overthebox-rework-homepage branch July 11, 2024 14:43
antonymarion pushed a commit that referenced this pull request Jul 15, 2024
@Steffy29 @ovh-cds @antonymarion
feat(overthebox): rework on detail view (#12144)
576accf 
ref: UXCT-600

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti approved these changes

@antonymarion antonymarion antonymarion approved these changes

@ghyenne ghyenne ghyenne left review comments

@qpavy qpavy qpavy left review comments

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene

Assignees

@Steffy29 Steffy29

Labels
quality check: ok translation required universe-telecom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Steffy29 @qpavy @antonymarion @anooparveti @ghyenne @darsene