Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci.savings-plan): create savings plan listing page #12147

Closed
wants to merge 1 commit into from
Closed

feat(pci.savings-plan): create savings plan listing page #12147

wants to merge 1 commit into from

Conversation

brofik
Copy link
Contributor

@brofik brofik commented Jun 26, 2024

ref: TAPC-856

Question Answer
Branch? pci/savings-plan
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-856
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jun 27, 2024
Base automatically changed from feat/TAPC-1084 to feat/pci-savings-plan June 27, 2024 12:57
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed has conflicts Has conflicts to resolve before merging labels Jun 27, 2024
feat(pci.savings-plan): create savings plan listing page
ffe88be 
ref: TAPC-856
Signed-off-by: Rafik Adiche <rafik.adiche.ext@corp.ovh.com>
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jun 27, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@lionel95200x lionel95200x deleted the branch feat/pci-savings-plan June 28, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brofik @lionel95200x