Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kms): add keys page routing #12150

Conversation

rjamet-ovh
Copy link
Contributor

Question Answer
Branch? feat/MANAGER-14283-2
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-14070
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add keys page routing

Related

@rjamet-ovh rjamet-ovh requested review from a team as code owners June 26, 2024 12:53
@rjamet-ovh rjamet-ovh requested review from sidlynx, seven-amid, antonymarion, MaximeBajeux and sachinrameshn and removed request for a team June 26, 2024 12:53
@github-actions github-actions bot added enabler feature New feature labels Jun 26, 2024
@rjamet-ovh rjamet-ovh force-pushed the feat/MANAGER-14070-keys-page-template branch from 98877fb to 7eb694b Compare June 26, 2024 15:06
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jun 27, 2024
@rjamet-ovh rjamet-ovh force-pushed the feat/MANAGER-14070-keys-page-template branch from 7eb694b to c574223 Compare June 27, 2024 13:54
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jun 27, 2024
vovh
vovh previously approved these changes Jun 28, 2024
darsene
darsene previously approved these changes Jun 28, 2024
chipp972
chipp972 previously approved these changes Jun 28, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jun 28, 2024
@rjamet-ovh rjamet-ovh force-pushed the feat/MANAGER-14070-keys-page-template branch from c574223 to 3c4eef2 Compare June 28, 2024 14:34
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jun 28, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jun 28, 2024
@rjamet-ovh rjamet-ovh force-pushed the feat/MANAGER-14070-keys-page-template branch from 3c4eef2 to 862b1f5 Compare July 1, 2024 07:30
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jul 1, 2024
Base automatically changed from feat/MANAGER-14283-2 to develop July 2, 2024 13:16
@darsene darsene dismissed stale reviews from aboungnaseng-ovhcloud, chipp972, vovh, and themself July 2, 2024 13:16

The base branch was changed.

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jul 2, 2024
@rjamet-ovh rjamet-ovh changed the base branch from develop to feat/key-management-service-B2 July 2, 2024 13:50
ref: MANAGER-14070

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
@rjamet-ovh rjamet-ovh force-pushed the feat/MANAGER-14070-keys-page-template branch from 862b1f5 to c4bfb98 Compare July 2, 2024 13:52
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jul 2, 2024
Copy link

sonarcloud bot commented Jul 2, 2024

@rjamet-ovh rjamet-ovh merged commit c4bfb98 into feat/key-management-service-B2 Jul 2, 2024
13 of 14 checks passed
@rjamet-ovh rjamet-ovh deleted the feat/MANAGER-14070-keys-page-template branch July 2, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants