Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hpc-vmware-managed-vcd): add new product VCD #12552

Merged
merged 77 commits into from
Oct 18, 2024
Merged

feat(hpc-vmware-managed-vcd): add new product VCD #12552

merged 77 commits into from
Oct 18, 2024

Conversation

darsene
Copy link
Contributor

@darsene darsene commented Jul 26, 2024

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-14354
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add VMware Cloud director product to the manager

Related

@darsene darsene changed the base branch from master to develop July 26, 2024 12:52
@github-actions github-actions bot removed build Changes that affect the build system or external dependencie universe-web-cloud documentation Documentation only changes dependencies Pull requests that update a dependency file universe-public-cloud sign-up manager-components common labels Jul 29, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 8, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarCloud found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@pauldkn pauldkn force-pushed the feat/hpc-vcd-beta branch 2 times, most recently from 4f5787e to 187fc34 Compare September 2, 2024 16:31
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Sep 3, 2024
@github-actions github-actions bot removed universe-hosted-private-cloud has conflicts Has conflicts to resolve before merging labels Sep 9, 2024
chipp972 and others added 16 commits October 18, 2024 11:32
@chipp972 @darsene
fix(hpc-vmware-managed-vcd): capitalize labels (#13481)
7374d9e 
ref: MANAGER-15506

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@darsene
feat(hpc-vmware-managed-vcd): update onboarding links for us
1807db5 
  ref: MANAGER-15295

Signed-off-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
@darsene
feat(hpc-vmware-managed-vcd): add suspense on manager button
b348757 
Signed-off-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
@chipp972 @darsene
fix(hpc-vmware-managed-vcd): fix compute datagrid labels (#13502)
ea9f9c2 
ref: MANAGER-15439

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@chipp972 @darsene
fix(hpc-vmware-managed-vcd): fix guide links (#13504)
e21a00c 
ref: MANAGER-15224

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@chipp972 @darsene
feat(hpc-vmware-managed-vcd): integration tests setup (#13528)
e9a7e2f 
ref: MANAGER-15566

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@darsene
feat(hpc-vmware-managed-vcd): fix vcd & vdc description lengths
d5f5b7f 
  desc: from 256 to 255 - backend limit
  ref: MANAGER-15411

Signed-off-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
@darsene
feat(dedicated.pcc): update VCD translation in services column
6489ae9 
  ref: MANAGER-15455

Signed-off-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
@darsene
feat(hpc-vmware-managed-vcd): revert fix compute datagrid labels (#13502
c9f9e3b 
)

  desc: This reverts commit d50446c. (#13502)
  ref: MANAGER-15439

Signed-off-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
@darsene
feat(hpc-vmware-managed-vcd): update vHost column name
35ddc13 
  ref: MANAGER-15439

Signed-off-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
@darsene
fix(hpc-managed-vcd): fix order limitation for compute/storage
2e81577 
ref: MANAGER-15651 MANAGER-15650

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@chipp972 @darsene
feat(hpc-vmware-managed-vcd): add integration tests (#13592)
58b8710 
ref: MANAGER-15566

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@chipp972 @darsene
feat(hpc-vmware-managed-vcd): add pcc-migration condition (#13635)
ea9a4c1 
ref: MANAGER-15398

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@darsene
feat(dedicated.pcc): update FF rule name for VCD migration
832dfa3 
ref: MANAGER-15398

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@darsene
fix(hpc-manage-vcd): fix yarn.lock & pcc guide config conflicts
5ea2b22 
ref: MANAGER-14354

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@darsene
fix(i18n): add missing translations [CDS 94]
2b61490 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 18, 2024
@darsene
fix(hpc-managed-vcd): update vitest version
c353a7f 
ref: MANAGER-14354

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@darsene darsene merged commit 0fc9531 into release/hpc-enabler-w43 Oct 18, 2024
11 of 14 checks passed
@darsene darsene deleted the feat/hpc-vcd-beta branch October 18, 2024 12:07
@darsene darsene mentioned this pull request Oct 18, 2024
Merged
5 tasks
darsene added a commit that referenced this pull request Oct 21, 2024
@darsene @tibs245
feat(hpc-vmware-managed-vcd): add new product VCD (#12552)
25a9dbb 
ref: MANAGER-14354

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
Co-authored-by: Thibault Barske <thibault.barske.ext@corp.ovh.com>
Co-authored-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
tibs245 added a commit that referenced this pull request Oct 21, 2024
@darsene @tibs245
feat(hpc-vmware-managed-vcd): add new product VCD (#12552)
a06808a 
ref: MANAGER-14354

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
Co-authored-by: Thibault Barske <thibault.barske.ext@corp.ovh.com>
Co-authored-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
darsene added a commit that referenced this pull request Oct 21, 2024
@darsene @tibs245
feat(hpc-vmware-managed-vcd): add new product VCD (#12552)
a32bcc9 
ref: MANAGER-14354

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
Co-authored-by: Thibault Barske <thibault.barske.ext@corp.ovh.com>
Co-authored-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
tibs245 added a commit that referenced this pull request Oct 21, 2024
@darsene @tibs245
feat(hpc-vmware-managed-vcd): add new product VCD (#12552)
36b3de0 
ref: MANAGER-14354

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
Co-authored-by: Thibault Barske <thibault.barske.ext@corp.ovh.com>
Co-authored-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
tibs245 added a commit that referenced this pull request Oct 21, 2024
@darsene @tibs245
feat(hpc-vmware-managed-vcd): add new product VCD (#12552)
f84a61a 
ref: MANAGER-14354

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
Co-authored-by: Thibault Barske <thibault.barske.ext@corp.ovh.com>
Co-authored-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
darsene added a commit that referenced this pull request Oct 21, 2024
@darsene @tibs245
feat(hpc-vmware-managed-vcd): add new product VCD (#12552)
8e2d6f3 
ref: MANAGER-14354

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
Co-authored-by: Thibault Barske <thibault.barske.ext@corp.ovh.com>
Co-authored-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
darsene added a commit that referenced this pull request Oct 21, 2024
@darsene @tibs245
feat(hpc-vmware-managed-vcd): add new product VCD (#12552)
c990a65 
ref: MANAGER-14354

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
Co-authored-by: Thibault Barske <thibault.barske.ext@corp.ovh.com>
Co-authored-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldkn pauldkn pauldkn approved these changes

@chipp972 chipp972 chipp972 approved these changes

@tibs245 tibs245 tibs245 approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
common container dependencies Pull requests that update a dependency file feature New feature translation required universe-bare-metal-cloud universe-hosted-private-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darsene @tibs245 @chipp972 @pauldkn