feat(pci-kubernetes): streams listing #12613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenautvh
requested review from
kqesar,
seven-amid,
antonymarion,
MaximeBajeux and
oalkabouss
and removed request for
a team
frenautvh
force-pushed
the
feat/DTCORE-2445
branch
from
4de922a
to
eb38229
Compare
github-actions
bot
added
the
has conflicts
frenautvh
force-pushed
the
feat/DTCORE-2485
branch
from
7c867bf
to
729fcc6
Compare
github-actions
bot
removed
the
has conflicts
kqesar
approved these changes
Aug 1, 2024
sidlynx
approved these changes
Aug 2, 2024
seven-amid
approved these changes
Aug 2, 2024
anooparveti
reviewed
Aug 2, 2024
Comment on lines
+215
to
+234
| export const pollOperation = async ( | ||
| serviceName: string, | ||
| operationId: string, | ||
| intervalMs = 1000, | ||
| ) => { | ||
| const poll = async () => { | ||
| const { data: op } = await v6.get( | ||
| `/dbaas/logs/${serviceName}/operation/${operationId}`, | ||
| ); | ||
| if (op.state === 'SUCCESS') { | ||
| return op; | ||
| } | ||
| if (op.state === 'ERROR') { | ||
| throw new Error(op); | ||
| } | ||
| await new Promise((resolve) => setTimeout(resolve, intervalMs)); | ||
| return poll(); | ||
| }; | ||
| return poll(); | ||
| }; |
There was a problem hiding this comment.
nitpick: Can we use refetchInterval on useQuery for polling.
There was a problem hiding this comment.
it's a good point and i tried to use useQuery at first but it turned out to be more complicated for a few reason :
- you want to have a conditional refetch interval so you have to define an additional state to handle the operation status
- you need to synchronize the useMutation so the onSuccess / onError is called only once the polling is done
i think it's simpler this way because the polling is done at a lower api level and the creation/deletion call will only be resolved once the operation is complete (which is what you always want) ; you also don't need the cache capabilities offered by react-query
github-actions
bot
added
the
has conflicts
ref: DTCORE-2485 Signed-off-by: Florian Renaut <florian.renaut@corp.ovh.com>
frenautvh
force-pushed
the
feat/DTCORE-2485
branch
from
729fcc6
to
0cb5640
Compare
github-actions
bot
removed
the
has conflicts
ref: DTCORE-2486 Signed-off-by: Florian Renaut <florian.renaut@corp.ovh.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add kubernetes streams listing