Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): display ssh key only if private repo #12876

Merged
merged 1 commit into from
Sep 5, 2024
Merged

feat(web): display ssh key only if private repo #12876

merged 1 commit into from
Sep 5, 2024

Conversation

antonymarion
Copy link
Contributor

@antonymarion antonymarion commented Aug 29, 2024 •
edited
Loading

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Feat#MANAGER-14955
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
    - [ ] Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
    - [ ] Breaking change is mentioned in relevant commits

Description

Related

@antonymarion antonymarion changed the title Feat/manager 14955 feat(web): display ssh key only if private repo Aug 29, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Aug 29, 2024
@antonymarion antonymarion marked this pull request as ready for review August 29, 2024 13:27
@antonymarion antonymarion requested a review from a team as a code owner August 29, 2024 13:27
@github-actions github-actions bot removed has conflicts Has conflicts to resolve before merging translation required labels Aug 29, 2024
feat(web): display ssh key only if private repo
bb6fda0 
  ref: MANAGER-14955

Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stif59100 stif59100 changed the base branch from master to release/webcollab-w36 September 5, 2024 12:07
@stif59100 stif59100 merged commit 21e5909 into release/webcollab-w36 Sep 5, 2024
15 checks passed
@stif59100 stif59100 deleted the feat/MANAGER-14955 branch September 5, 2024 12:08
stif59100 pushed a commit that referenced this pull request Sep 5, 2024
@antonymarion @stif59100
feat(web): display ssh key only if private repo (#12876)
5336f6a 
ref: MANAGER-14955

Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
Co-authored-by: Antony MARION <antony.marion.ext@ovhcloud.com>
stif59100 pushed a commit that referenced this pull request Sep 6, 2024
@antonymarion @stif59100
feat(web): display ssh key only if private repo (#12876)
8534029 
ref: MANAGER-14955

Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
Co-authored-by: Antony MARION <antony.marion.ext@ovhcloud.com>
stif59100 added a commit that referenced this pull request Sep 6, 2024
@stif59100
Temp/release/webcollab w36 (#12971)
42a9e41 
* fix(i18n): add missing translations [CDS 3202] (#12565)

ref: PRB0040219

Signed-off-by: CDS Translator Agent <opensource@ovh.net>

* feat(domains): add domain status (#12720)

ref: MANAGER-14981

Signed-off-by: Julien Vaumoron <julien.vaumoron.ext@ovhcloud.com>

* feat(web): display ssh key only if private repo (#12876)

ref: MANAGER-14955

Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>

* feat(hosting.multisite): prevent action on main domain (#12198)

ref:WEB-18751

Signed-off-by: Lucas Chaigne <lucas.chaigne@ovhcloud.com>

* feat(telecom.pack): display adsl and vdsl accesses first (#12733)

ref: UXCT-608

Signed-off-by: Stephanie Moallic <stephanie.moallic@corp.ovh.com>

* feat(domains): process autorenew status  (#12588)

ref: MANAGER-14947

Signed-off-by: Julien Vaumoron <julien.vaumoron.ext@ovhcloud.com>
Co-authored-by:  CDS Translator Agent <opensource@ovh.net>

* feat(zimbra): project zimbra beta (#11715)

ref:MANAGER-13738

Signed-off-by: stif59100 <steeve.vanderstocken@ovhcloud.com>
stif59100 pushed a commit that referenced this pull request Sep 6, 2024
@antonymarion @stif59100
feat(web): display ssh key only if private repo (#12876)
67afaa7 
ref: MANAGER-14955

Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
stif59100 pushed a commit that referenced this pull request Sep 6, 2024
@antonymarion @stif59100
feat(web): display ssh key only if private repo (#12876)
4309ed6 
ref: MANAGER-14955

Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
@stif59100 stif59100 mentioned this pull request Sep 6, 2024
Merged
6 tasks
stif59100 pushed a commit that referenced this pull request Sep 9, 2024
@antonymarion @stif59100
feat(web): display ssh key only if private repo (#12876)
d3c3169 
ref: MANAGER-14955

Signed-off-by: Antony MARION <antony.marion.ext@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@darsene darsene darsene approved these changes

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature quality check: ok universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonymarion @darsene @JacquesLarique @stif59100