Fix issue #3: HTTPS proxy support through custom agent #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @param {Object} httpsAgent: the custom HTTPS agent | ||
| */ | ||
| Ovh.prototype.setCustomHTTPSAgent = function (httpsAgent) { |
There was a problem hiding this comment.
Constructor is "agent", internal is "httpsAgent", setter is "customHTTPSAgent". Please pick one :)
There was a problem hiding this comment.
Right. I have picked one in the updated commit :)
|
Thanks for your contribution! Quality is a must-have for OVH. Can you provide relevant tests and documentation for this patch? Thanks. |
…tor and a setter. Fixes ovh#3. Signed-off-by: Lionel Debroux <lionel_debroux@yahoo.fr>
|
|
Still no support for proxy settings ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the outcome of the discussion in issue #3 , and made a quick local test from behind an HTTPS proxy, which accessed the server successfully.
As far as naming is concerned, maybe the property in params should be named "httpsAgent" for consistency, or the "https" / "HTTPS" strings should go away ?