Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(colors): replace legacy colors by tokens #93

Merged
merged 2 commits into from
May 13, 2020

Conversation

AxelPeter
Copy link
Contributor

All legacy colors has been replaced by the corresponding ODS tokens.
Except for @oui-color-primary, @oui-color-secondary, @oui-color-tertiary and @oui-color-brand.

Signed-off-by: Axel Peter <axel.peter@live.com>
Copy link
Member

@antleblanc antleblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Please let me know if you want me to open an issue for instance because
I'm having trouble to understand why docs/assets/css/oui-bs3.css.map file are
listed here.

It shouldn't be there except if there is a case to cover that I'm not aware of.
Thank you!

// color: @oui-color-silver;
// border-color: @oui-color-concrete;
// background-color: @oui-color-concrete;
// color: @g-300;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part couldn't be removed? (commented code)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll remove those parts

@AxelPeter
Copy link
Contributor Author

To view the changes in the demo page, we need to rebuild the assets files.
With this project, we don't bother with any grunt or webpack config (since it was supposed to be temporary :) )

Signed-off-by: Axel Peter <axel.peter@live.com>
@antleblanc antleblanc self-requested a review May 12, 2020 17:25
@antleblanc
Copy link
Member

To view the changes in the demo page, we need to rebuild the assets files.
With this project, we don't bother with any grunt or webpack config (since it was supposed to be temporary :) )

Thank you for the information.

Maybe we can consider to stop versioning the *.map files into the docs folder.
Here is an attempt to address it: #95

Please let me know what do you think.

Thanks

@AxelPeter
Copy link
Contributor Author

I don't agree, because the .map file works with the versioned CSS file. If we rebuild the LESS files, the references of the map file changes according to its source files. So it needs to be versioned with the CSS file.

It has its place in the docs folder because the demo page is used as a dev environment.

@antleblanc
Copy link
Member

I don't agree, because the .map file works with the versioned CSS file. If we rebuild the LESS files, the references of the map file changes according to its source files. So it needs to be versioned with the CSS file.

It has its place in the docs folder because the demo page is used as a dev environment.

I'm OK with the purpose of the *.map files here and generally but it could be questioned for this project, especially for the docs folder.

We can keep it as is for the scope of this Pull Request in order to be able to merge it and then continue the disccussion here #95

Thanks

@AxelPeter AxelPeter merged commit 7f018be into master May 13, 2020
@AxelPeter AxelPeter deleted the refactor/remove-legacy-colors branch May 13, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants