-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(colors): replace legacy colors by tokens #93
Conversation
Signed-off-by: Axel Peter <axel.peter@live.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Please let me know if you want me to open an issue for instance because
I'm having trouble to understand why docs/assets/css/oui-bs3.css.map
file are
listed here.
It shouldn't be there except if there is a case to cover that I'm not aware of.
Thank you!
src/less/bootstrap/pagination.less
Outdated
// color: @oui-color-silver; | ||
// border-color: @oui-color-concrete; | ||
// background-color: @oui-color-concrete; | ||
// color: @g-300; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part couldn't be removed? (commented code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'll remove those parts
To view the changes in the demo page, we need to rebuild the |
Signed-off-by: Axel Peter <axel.peter@live.com>
Thank you for the information. Maybe we can consider to stop versioning the Please let me know what do you think. Thanks |
I don't agree, because the It has its place in the |
I'm OK with the purpose of the We can keep it as is for the scope of this Pull Request in order to be able to merge it and then continue the disccussion here #95 Thanks |
All legacy colors has been replaced by the corresponding ODS tokens.
Except for
@oui-color-primary
,@oui-color-secondary
,@oui-color-tertiary
and@oui-color-brand
.