Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: setup-gpg.sh: create additional backup signing config with --generate #409

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

docwalter
Copy link

#243 allows for signed backups, but setup-gpg.sh --generate only creates signing config for session recording backups so far. With this code, setup-gpg.sh generates a config snippet for signing configuration backups, too.

Since the signing key passphrase can contain arbitrary special characters, it is wrapped in single quotes and any contained single quote ' is escaped as '\''. Tested it successfully with a several generated signing key passphrases, including ones with single quotes.

Signed-off-by: Philipp Walter p.walter@infoserve.de

@speed47
Copy link
Collaborator

speed47 commented Aug 22, 2023

You're right, that was a missing part of the setup script indeed.

Thanks for your contribution and testing, lgtm :)

@speed47 speed47 merged commit e616f24 into ovh:master Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants