Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed result from testcase variables and removed errors warning and info from non verbose runs #617

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jan 27, 2023

kpaquier added 2 commits January 30, 2023 10:15
Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
…ue in teststep and show info before errors

Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Copy link
Member

@yesnault yesnault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @kilianpaquier

@yesnault yesnault merged commit 0d936bf into ovh:master Feb 14, 2023
yesnault added a commit that referenced this pull request Feb 14, 2023
…rs warning and info from non verbose runs (#617)"

This reverts commit 0d936bf.
yesnault added a commit that referenced this pull request Feb 14, 2023
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
Copy link
Member

revert. Intergration Tests are failing, example: venom run interpolate_once.yml

@kilianpaquier
Copy link
Contributor Author

revert. Intergration Tests are failing, example: venom run interpolate_once.yml

Yes sorry, didn't see that one. It doesn't work anymore because I removed all .result from testcase variables.

Only the assigned variables (coming from the key 'vars') are present in testcase variables, that's why interpolation.yaml doesn't fail.

In my opinion, .result should be teststep scoped. If .result must be accessed later, then it should be assigned to a variable during the teststep. It is because every step computes a .result and if multiple steps are to compute .result.systemout, all of them would be stored in the testcase variables but only the last one would be used.

In this case, result.systemout should be assign to a variable, and the comparison should be done with it. Just like it's done in interpolation.yaml.

Another possibility is to prefix .result with the teststep name, like it is done on variable in different testcases.

yesnault added a commit that referenced this pull request Feb 15, 2023
* Revert "feat: removed result from testcase variables and removed errors warning and info from non verbose runs (#617)"

This reverts commit 0d936bf.

* fix: revert #617

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>

* Update interpolate_once.yml

---------

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@kilianpaquier
Copy link
Contributor Author

revert. Intergration Tests are failing, example: venom run interpolate_once.yml

Yes sorry, didn't see that one. It doesn't work anymore because I removed all .result from testcase variables.

Only the assigned variables (coming from the key 'vars') are present in testcase variables, that's why interpolation.yaml doesn't fail.

In my opinion, .result should be teststep scoped. If .result must be accessed later, then it should be assigned to a variable during the teststep. It is because every step computes a .result and if multiple steps are to compute .result.systemout, all of them would be stored in the testcase variables but only the last one would be used.

In this case, result.systemout should be assign to a variable, and the comparison should be done with it. Just like it's done in interpolation.yaml.

Another possibility is to prefix .result with the teststep name, like it is done on variable in different testcases.

Hello @yesnault, what do you think ?

ivan-velasco pushed a commit to socotra/venom that referenced this pull request Sep 20, 2023
…ng and info from non verbose runs (ovh#617)

* feat: removed ranged stdout on non-verbose runs

Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>

* feat: remove tc computedInfo, fix info not showing right variable value in teststep and show info before errors

Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>

---------

Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Co-authored-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
ivan-velasco pushed a commit to socotra/venom that referenced this pull request Sep 20, 2023
* Revert "feat: removed result from testcase variables and removed errors warning and info from non verbose runs (ovh#617)"

This reverts commit 0d936bf.

* fix: revert ovh#617

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>

* Update interpolate_once.yml

---------

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print info in current "step" before assertions Improving error debugging (especially in CI)
2 participants