Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Logging level flag added #668

Closed
wants to merge 3 commits into from

Conversation

ivan-velasco
Copy link
Contributor

  • feature: to partially solve this issue, introduced loggingLevel
  • supported values are based on logrus package
"panic"
"fatal"
"error"
"warn"
"info"
"debug"
"trace"

#666

Additional discussion should occur as this logging package is in maintenance mode and performance is not the best. Migrate to a different library in the future. For instance https://github.com/rs/zerolog

Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
@fokion
Copy link
Contributor

fokion commented May 20, 2023

Looks good

@yesnault
Copy link
Member

yesnault commented Jun 1, 2023

Hi @ivan-velasco , thank you for this proposal, this brings back this logs topic back.

We don't want to add a argument to manage log level, the verbose flag is here for that. Btw, here a PR to manage the log verbosity with the verbose flag (-v is INFO, -vv is DEBUG, default is WARN): #675

@yesnault yesnault closed this Jun 1, 2023
@ivan-velasco ivan-velasco deleted the feature/logging-levels branch June 1, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants