Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getStep() returns NaN when only one step is present #68

Closed
flosell opened this issue Dec 16, 2014 · 0 comments
Closed

getStep() returns NaN when only one step is present #68

flosell opened this issue Dec 16, 2014 · 0 comments

Comments

@flosell
Copy link
Collaborator

flosell commented Dec 16, 2014

We are using Dragdealer for a widget that's dynamically filled with content, so it can happen that it ends up with only one step.

In this case, getStep() returns [NaN,NaN]. This might be an edge-case but I'd expect [1,1] here.

Example:
http://jsbin.com/wiwexojiqu/2/edit?html,js,output
flosell added a commit to flosell/dragdealer that referenced this issue Dec 30, 2014
@flosell
add skiddings improved solution to ovidiuch#68 (see comments in pull …
4836f5c 
…request ovidiuch#69)
ovidiuch added a commit that referenced this issue Dec 31, 2014
@ovidiuch
Merge pull request #69 from flosell/fix-issue-68
90fb506 
Fix for issue #68: return consistent values from getSteps(), getClosestStep(), ... when only one slide is available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flosell