Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not activate it automatically #15

Closed
debugger22 opened this issue May 13, 2014 · 14 comments
Closed

Do not activate it automatically #15

debugger22 opened this issue May 13, 2014 · 14 comments

Comments

@debugger22
Copy link

It would be great if user could configure the automatically activation feature.

@debugger22 debugger22 changed the title Do not activate it automtically Do not activate it automatically May 13, 2014
@buchgr
Copy link

buchgr commented May 13, 2014

👍

1 similar comment
@jnordberg
Copy link

👍

@buunguyen
Copy link
Collaborator

This is the current behavior of the extension: it will pop out automatically after you install it the first time. If you close it by clicking the hamburger icon in the bottom-left corner, it will remained hidden until you open it, access a private repository or exceed the API limit, in which case it pops out to prompt for the access token.

Is this behavior not what you're observing or expecting?

@jnordberg
Copy link

No, it's popping open randomly it feels like

@jnordberg
Copy link

It might have been that it didn't have a access token, created one now and it seems to behave.

@debugger22
Copy link
Author

I agree with @jnordberg It opens up every time I navigate to a repository.

@buunguyen
Copy link
Collaborator

@debugger22 and does it say something like "API limit exceed", or "private or invalid repository"? Or does it show the code tree? If the latter, can you open up the Chrome console, go to Resources > Local Storage, look for the octotree.shown key and see if its value gets changed everytime you click the toggle button? Thanks a lot.

@debugger22
Copy link
Author

I'm sorry. It is working now. 😄
You can close this issue if its fine with others.

@debugger22
Copy link
Author

The problem is that when you navigate to some page like "stargazers", it opens up with "private or invalid repository" and when you come back to a valid repository, it again shows the tree irrespective of the previous setting.

@buunguyen
Copy link
Collaborator

Ah, I see. The right behavior is not showing the tree at all (regardless of settings) when people are not in code area. It's something I'm working on.

@timoxley
Copy link

👍

  • Should be disabled by default.
  • Should be activated by hotkey or extension button.
  • Should also display an activation button on the homepage for a repo, or while browsing the tree.

Imagine if developer tools opened on every website automatically? Also the transition adds to irritating behaviour by making it very obvious that it's opening. Transition should only happen on first time switch from deactive to active. If previous page had panel open, it should not use transition.

@ghost
Copy link

ghost commented May 14, 2014

Agreed. I wish it were closed by default, and maybe also had a shortcut key to open.

@buunguyen
Copy link
Collaborator

Just an update. I've just merged a pull request that hides Octotree completely when navigating to non-code pages (e.g. stargazers, issues etc.) I hope this will make Octotree less annoying in such circumstances.

Further discussion on this topic should be directed to this thread: #32.

@ghost
Copy link

ghost commented May 15, 2014

Myself, I'd still rather have the option to set it not to be open by default for any page.

@buunguyen buunguyen added bug and removed bug labels May 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants