Fix IC address set usage. #183
Conversation
.cirrus.yml
Outdated
| - 'for ip4 in True False; do | ||
| for ip6 in True False; do |
There was a problem hiding this comment.
Can we create a matrix instead of putting 3 different tests into one?
There was a problem hiding this comment.
It took some effort and it has some downsides but I pushed it to the PR as it is cleaner. One thing we might have to adjust is the matrix size. Especially with the thought in mind that we'll be adding OpenStack scenarios too.
dceara
force-pushed
the
fix-ic-address-set
branch
from
883370b
to
ac3cba3
Compare
.cirrus.yml
Outdated
| runtime_cache: | ||
| folder: runtime-cache | ||
| fingerprint_script: | ||
| - echo ${CIRRUS_BUILD_ID} |
There was a problem hiding this comment.
This is a little concerning. We could consider going back to a simple loop, but we could also consider having a separate global and local to the job caches to save CPU cycles.
There was a problem hiding this comment.
I'll remove the commit that increases CI coverage from this PR. We need the address set fix sooner rather than later. I'll open an issue to track adding global and local to the job caches to save CPU cycles.
.cirrus.yml
Outdated
| memory: 8G | ||
| disk: 40 |
There was a problem hiding this comment.
Looking at the resource usage, we could, likely reduce the cpu count from the default 2 to 1.
We probably don't need 8G of RAM as well, but I'm not sure why ubuntu builds eat almost 4, while fedora builds only use ~500 MB.
Namespaces can (in theory) have different address family address sets in different IC clusters. Instead of checking the address set array (always not None), check to see if the corresponding per-AZ address set actually exists. Fixes: 2562afb ("ovn-tester: extend density_light testing for ovn-ic") Signed-off-by: Dumitru Ceara <dceara@redhat.com>
dceara
force-pushed
the
fix-ic-address-set
branch
from
ac3cba3
to
5eb6eb1
Compare
dceara
changed the title
No description provided.